Re: [Mesa-dev] [PATCH] nir: acknowledge the existence of nir_builder.h

2015-03-30 Thread Emil Velikov
On 30 March 2015 at 18:34, Matt Turner wrote: > On Mon, Mar 30, 2015 at 10:23 AM, Emil Velikov > wrote: >> On 30 March 2015 at 18:10, Matt Turner wrote: >>> No, it doesn't make sense. Presumably you added it because it fixed a >>> build error? Maybe if you showed what the error was it would mak

Re: [Mesa-dev] [PATCH] nir: acknowledge the existence of nir_builder.h

2015-03-30 Thread Matt Turner
On Mon, Mar 30, 2015 at 10:23 AM, Emil Velikov wrote: > On 30 March 2015 at 18:10, Matt Turner wrote: >> No, it doesn't make sense. Presumably you added it because it fixed a >> build error? Maybe if you showed what the error was it would make >> sense. >> > Hmm... ok. Can you elaborate if on the

Re: [Mesa-dev] [PATCH] nir: acknowledge the existence of nir_builder.h

2015-03-30 Thread Emil Velikov
On 30 March 2015 at 18:10, Matt Turner wrote: > On Mon, Mar 30, 2015 at 9:58 AM, Emil Velikov > wrote: >> On 30 March 2015 at 17:37, Eric Anholt wrote: >>> Emil Velikov writes: >>> On 30/03/15 02:05, Eric Anholt wrote: > Emil Velikov writes: > >> ... >> diff --git a/src/glsl/

Re: [Mesa-dev] [PATCH] nir: acknowledge the existence of nir_builder.h

2015-03-30 Thread Matt Turner
On Mon, Mar 30, 2015 at 9:58 AM, Emil Velikov wrote: > On 30 March 2015 at 17:37, Eric Anholt wrote: >> Emil Velikov writes: >> >>> On 30/03/15 02:05, Eric Anholt wrote: Emil Velikov writes: > ... > diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am > index ed90366..58af

Re: [Mesa-dev] [PATCH] nir: acknowledge the existence of nir_builder.h

2015-03-30 Thread Emil Velikov
On 30 March 2015 at 17:37, Eric Anholt wrote: > Emil Velikov writes: > >> On 30/03/15 02:05, Eric Anholt wrote: >>> Emil Velikov writes: >>> ... diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am index ed90366..58af166 100644 --- a/src/glsl/Makefile.am +++ b/src/glsl/Ma

Re: [Mesa-dev] [PATCH] nir: acknowledge the existence of nir_builder.h

2015-03-30 Thread Eric Anholt
Emil Velikov writes: > On 30/03/15 02:05, Eric Anholt wrote: >> Emil Velikov writes: >> >>> The header was added with commit 2a135c470e3(nir: Add an ALU op builder >>> kind of like ir_builder.h) but did not made it into to the sources list, >>> and its dependency of nir_builder_opcodes.h was mi

Re: [Mesa-dev] [PATCH] nir: acknowledge the existence of nir_builder.h

2015-03-30 Thread Emil Velikov
On 30/03/15 02:05, Eric Anholt wrote: > Emil Velikov writes: > >> The header was added with commit 2a135c470e3(nir: Add an ALU op builder >> kind of like ir_builder.h) but did not made it into to the sources list, >> and its dependency of nir_builder_opcodes.h was missing. >> >> Fortunately it re

Re: [Mesa-dev] [PATCH] nir: acknowledge the existence of nir_builder.h

2015-03-29 Thread Eric Anholt
Emil Velikov writes: > The header was added with commit 2a135c470e3(nir: Add an ALU op builder > kind of like ir_builder.h) but did not made it into to the sources list, > and its dependency of nir_builder_opcodes.h was missing. > > Fortunately it remained unused until resent commit faf6106c6f6(n

[Mesa-dev] [PATCH] nir: acknowledge the existence of nir_builder.h

2015-03-28 Thread Emil Velikov
The header was added with commit 2a135c470e3(nir: Add an ALU op builder kind of like ir_builder.h) but did not made it into to the sources list, and its dependency of nir_builder_opcodes.h was missing. Fortunately it remained unused until resent commit faf6106c6f6(nir: Implement a Mesa IR -> NIR t