Re: [Mesa-dev] [PATCH] nir: add lowering for gl_HelperInvocation

2018-06-25 Thread Ilia Mirkin
On Mon, Jun 25, 2018 at 2:38 PM, Rob Clark wrote: > On Mon, Jun 25, 2018 at 2:29 PM, Ilia Mirkin wrote: >> On Mon, Jun 25, 2018 at 2:23 PM, Ian Romanick wrote: >>> On 06/19/2018 08:24 AM, Rob Clark wrote: v2: reword comment about lower_helper_invocations to be more clear that it mi

Re: [Mesa-dev] [PATCH] nir: add lowering for gl_HelperInvocation

2018-06-25 Thread Rob Clark
On Mon, Jun 25, 2018 at 2:29 PM, Ilia Mirkin wrote: > On Mon, Jun 25, 2018 at 2:23 PM, Ian Romanick wrote: >> On 06/19/2018 08:24 AM, Rob Clark wrote: >>> v2: reword comment about lower_helper_invocations to be more clear >>> that it might not work on all hardware >>> v3: add special variant

Re: [Mesa-dev] [PATCH] nir: add lowering for gl_HelperInvocation

2018-06-25 Thread Ilia Mirkin
On Mon, Jun 25, 2018 at 2:23 PM, Ian Romanick wrote: > On 06/19/2018 08:24 AM, Rob Clark wrote: >> v2: reword comment about lower_helper_invocations to be more clear >> that it might not work on all hardware >> v3: add special variant of load_sample_id which does not imply per- >> sample s

Re: [Mesa-dev] [PATCH] nir: add lowering for gl_HelperInvocation

2018-06-25 Thread Ian Romanick
On 06/19/2018 08:24 AM, Rob Clark wrote: > v2: reword comment about lower_helper_invocations to be more clear > that it might not work on all hardware > v3: add special variant of load_sample_id which does not imply per- > sample shading > > Signed-off-by: Rob Clark > --- > Yeah, new intr

[Mesa-dev] [PATCH] nir: add lowering for gl_HelperInvocation

2018-06-19 Thread Rob Clark
v2: reword comment about lower_helper_invocations to be more clear that it might not work on all hardware v3: add special variant of load_sample_id which does not imply per- sample shading Signed-off-by: Rob Clark --- Yeah, new intrinsic name is a bit funny sounding, but I couldn't think