Re: [Mesa-dev] [PATCH] nir: fix nir_remove_unused_varyings()

2019-04-25 Thread Dylan Baker
Thanks! Quoting Timothy Arceri (2019-04-25 15:36:44) > On 26/4/19 6:50 am, Dylan Baker wrote: > > Hi Tim, > > > > I had to make a couple of small tweaks to get this to apply against 19.0 > > (namely > > that the glsl_type_is_struct -> glsl_type_is_struct_or_ifc doesn't exist in > > 19.0), could

Re: [Mesa-dev] [PATCH] nir: fix nir_remove_unused_varyings()

2019-04-25 Thread Timothy Arceri
On 26/4/19 6:50 am, Dylan Baker wrote: Hi Tim, I had to make a couple of small tweaks to get this to apply against 19.0 (namely that the glsl_type_is_struct -> glsl_type_is_struct_or_ifc doesn't exist in 19.0), could you take a look at the patch in the staging/19.0 branch and let me know if it l

Re: [Mesa-dev] [PATCH] nir: fix nir_remove_unused_varyings()

2019-04-25 Thread Dylan Baker
Hi Tim, I had to make a couple of small tweaks to get this to apply against 19.0 (namely that the glsl_type_is_struct -> glsl_type_is_struct_or_ifc doesn't exist in 19.0), could you take a look at the patch in the staging/19.0 branch and let me know if it looks okay? Thanks, Dylan Quoting Timoth

Re: [Mesa-dev] [PATCH] nir: fix nir_remove_unused_varyings()

2019-04-24 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset Thanks fo the fix Tim! On 4/25/19 3:17 AM, Timothy Arceri wrote: We were only setting the used mask for the first component of a varying. Since the linking opts split vectors into scalars this has mostly worked ok. However this causes an issue where for example if

[Mesa-dev] [PATCH] nir: fix nir_remove_unused_varyings()

2019-04-24 Thread Timothy Arceri
We were only setting the used mask for the first component of a varying. Since the linking opts split vectors into scalars this has mostly worked ok. However this causes an issue where for example if we split a struct on one side of the interface but not the other, then we can possibly end up remo