Re: [Mesa-dev] [PATCH] nouveau: fix frees in unsupported IR error paths.

2019-06-18 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Jun 18, 2019 at 5:14 PM Dave Airlie wrote: > > From: Dave Airlie > > This is pointless in that we won't ever hit those paths in real life, > but coverity complains. > > Fixes: f014ae3c7cce ("nouveau: add support for nir") > --- > src/gallium/drivers/nouveau/nv5

Re: [Mesa-dev] [PATCH] nouveau: fix frees in unsupported IR error paths.

2019-06-18 Thread Karol Herbst
On Tue, Jun 18, 2019 at 11:14 PM Dave Airlie wrote: > > From: Dave Airlie > > This is pointless in that we won't ever hit those paths in real life, > but coverity complains. > what does it actually complain about? > Fixes: f014ae3c7cce ("nouveau: add support for nir") > --- > src/gallium/drive

Re: [Mesa-dev] [PATCH] nouveau: fix frees in unsupported IR error paths.

2019-06-18 Thread Karol Herbst
ohh, nvm... I already know... On Tue, Jun 18, 2019 at 11:18 PM Karol Herbst wrote: > > On Tue, Jun 18, 2019 at 11:14 PM Dave Airlie wrote: > > > > From: Dave Airlie > > > > This is pointless in that we won't ever hit those paths in real life, > > but coverity complains. > > > > what does it act

[Mesa-dev] [PATCH] nouveau: fix frees in unsupported IR error paths.

2019-06-18 Thread Dave Airlie
From: Dave Airlie This is pointless in that we won't ever hit those paths in real life, but coverity complains. Fixes: f014ae3c7cce ("nouveau: add support for nir") --- src/gallium/drivers/nouveau/nv50/nv50_program.c | 1 + src/gallium/drivers/nouveau/nv50/nv50_state.c | 2 ++ src/gallium/dri