Your patch doesn't compile because you forgot to include
"util/u_framebuffer.h"
nv50/nv50_state.c: In function ‘nv50_set_framebuffer_state’:
nv50/nv50_state.c:942:4: error: implicit declaration of function
‘util_copy_framebuffer_state’ [-Werror=implicit-function-declaration]
We already have this logic in the gallium/util functions so
lets reduce some entropy while here.
V.2:
Apply change to nv50 also as suggested by Samuel Pitoiset.
Signed-off-by: Edward O'Callaghan
---
src/gallium/drivers/nouveau/nv50/nv50_state.c | 13
On 02/14/2016 10:54 PM, Edward O'Callaghan wrote:
We already have this logic in the gallium/util functions so
lets reduce some entropy while here.
V.2:
Apply change to nv50 also as suggested by Samuel Pitoiset.
Signed-off-by: Edward O'Callaghan
Could you
On 02/14/2016 11:04 PM, Ilia Mirkin wrote:
On Sun, Feb 14, 2016 at 5:00 PM, Samuel Pitoiset
wrote:
On 02/14/2016 10:54 PM, Edward O'Callaghan wrote:
We already have this logic in the gallium/util functions so
lets reduce some entropy while here.
V.2:
Apply
On Sun, Feb 14, 2016 at 5:00 PM, Samuel Pitoiset
wrote:
>
>
> On 02/14/2016 10:54 PM, Edward O'Callaghan wrote:
>>
>> We already have this logic in the gallium/util functions so
>> lets reduce some entropy while here.
>>
>> V.2:
>>Apply change to nv50 also as
Reviewed-by: Ilia Mirkin
On Sun, Feb 14, 2016 at 4:54 PM, Edward O'Callaghan
wrote:
> We already have this logic in the gallium/util functions so
> lets reduce some entropy while here.
>
> V.2:
> Apply change to nv50 also as suggested by