[Mesa-dev] [PATCH] nvc0/ir: use the combined tid special register

2018-07-06 Thread Rhys Perry
total instructions in shared programs : 5804448 -> 5804690 (0.00%) total gprs used in shared programs: 670065 -> 670065 (0.00%) total shared used in shared programs : 548832 -> 548832 (0.00%) total local used in shared programs : 21068 -> 21068 (0.00%) local shared

Re: [Mesa-dev] [PATCH] nvc0/ir: use the combined tid special register

2018-07-06 Thread Rhys Perry
This patch doesn't touch NTID since it seems very difficult (or impossible) to generate. Seemingly because the state tracker or glsl compiler is turning gl_WorkGroupSize into a immediate. Such a transformation is not possible with GL_ARB_compute_variable_group_size but gl_WorkGroupSize is not avail

Re: [Mesa-dev] [PATCH] nvc0/ir: use the combined tid special register

2018-07-06 Thread Karol Herbst
somehow it doesn't really look like that it is worth the effort as the generated shaders are worse in avg? On Fri, Jul 6, 2018 at 10:32 PM, Rhys Perry wrote: > This patch doesn't touch NTID since it seems very difficult (or > impossible) to generate. Seemingly because the state tracker or glsl >

Re: [Mesa-dev] [PATCH] nvc0/ir: use the combined tid special register

2018-07-06 Thread Ilia Mirkin
Are they? Fewer special reg loads = better... On Fri, Jul 6, 2018 at 8:31 PM, Karol Herbst wrote: > somehow it doesn't really look like that it is worth the effort as the > generated shaders are worse in avg? > > On Fri, Jul 6, 2018 at 10:32 PM, Rhys Perry wrote: >> This patch doesn't touch NTID

Re: [Mesa-dev] [PATCH] nvc0/ir: use the combined tid special register

2018-07-06 Thread Karol Herbst
okay right, if loading those special regs is indeed more expensive than doing the read + a few extbf then I see the point of this optimization On Sat, Jul 7, 2018 at 2:46 AM, Ilia Mirkin wrote: > Are they? Fewer special reg loads = better... > > On Fri, Jul 6, 2018 at 8:31 PM, Karol Herbst wrote

Re: [Mesa-dev] [PATCH] nvc0/ir: use the combined tid special register

2018-07-06 Thread Karol Herbst
anyway, I think it might make sense to take a look at the shaders hurt most as I suspect there might be a way to improve the situation a little On Sat, Jul 7, 2018 at 3:38 AM, Karol Herbst wrote: > okay right, if loading those special regs is indeed more expensive > than doing the read + a few ex

Re: [Mesa-dev] [PATCH] nvc0/ir: use the combined tid special register

2018-07-07 Thread Rhys Perry
I don't really see how things like RDSV(COMBINED_TID) + EXTBF + EXTBF can be improved unless you create separate RDSV instructions (which is against the point of this patch) or merge the EXTBF with later instructions (and I don't really see how that can be done). It's only increases the size of gl

Re: [Mesa-dev] [PATCH] nvc0/ir: use the combined tid special register

2018-07-07 Thread Karol Herbst
On Sat, Jul 7, 2018 at 12:56 PM, Rhys Perry wrote: > I don't really see how things like RDSV(COMBINED_TID) + EXTBF + EXTBF > can be improved unless you create separate RDSV instructions (which is > against the point of this patch) or merge the EXTBF with later > instructions (and I don't really se