Re: [Mesa-dev] [PATCH] r600g: Avoid setting one gpu register multiple times in a r600_pipe_state

2011-03-15 Thread Michel Dänzer
On Mon, 2011-03-14 at 07:45 +0100, Mathias Fröhlich wrote: > > On Sunday, March 13, 2011 17:34:08 Henri Verbeet wrote: > > Ok, pushed. You had some whitespace issues, I've fixed those, but for > > future reference please note that r600g uses tabs for indentation. > Ok. I hoped that I always did s

Re: [Mesa-dev] [PATCH] r600g: Avoid setting one gpu register multiple times in a r600_pipe_state

2011-03-14 Thread Henri Verbeet
2011/3/14 Mathias Fröhlich : > I had, for a different project/source combination, already some kind of folder > name matching in my emacs configuration that dynamically switches the coding > style. But that is somehow complicated to install and making the directory > matches foolproof is not always

Re: [Mesa-dev] [PATCH] r600g: Avoid setting one gpu register multiple times in a r600_pipe_state

2011-03-14 Thread Tormod Volden
2011/3/14 Mathias Fröhlich wrote: > By that way, I use currently git format-patch and attach these files. > But the output of format-patch is clearly something that could go directly to > a mail delivery agent. But since I only use authenticated mail delivery with a > foreign sendmail/postfix serve

Re: [Mesa-dev] [PATCH] r600g: Avoid setting one gpu register multiple times in a r600_pipe_state

2011-03-13 Thread Mathias Fröhlich
Hi, On Sunday, March 13, 2011 17:34:08 Henri Verbeet wrote: > Ok, pushed. You had some whitespace issues, I've fixed those, but for > future reference please note that r600g uses tabs for indentation. Ok. I hoped that I always did so. The coding stlye configuration for the mesa hacking user is t

Re: [Mesa-dev] [PATCH] r600g: Avoid setting one gpu register multiple times in a r600_pipe_state

2011-03-13 Thread Henri Verbeet
2011/3/13 Mathias Fröhlich : > It does not fix anything. This change is supposed to produce the same command > stream than before. > I discovered that r600_context_pipe_state_set is one of the userspace > functions that are high in profiles for my use cases, I was looking for > duplicate registers

Re: [Mesa-dev] [PATCH] r600g: Avoid setting one gpu register multiple times in a r600_pipe_state

2011-03-13 Thread Mathias Fröhlich
Hi Henri, On Saturday, March 12, 2011 15:38:48 Henri Verbeet wrote: > 2011/3/12 Mathias Fröhlich : > > Attached is a patch to the r600g driver that avoids setting one specific > > gpu register multiple times within a r600_pipe_state struct. > > Is this supposed to fix anything in particular? The

Re: [Mesa-dev] [PATCH] r600g: Avoid setting one gpu register multiple times in a r600_pipe_state

2011-03-12 Thread Henri Verbeet
2011/3/12 Mathias Fröhlich : > Attached is a patch to the r600g driver that avoids setting one specific gpu > register multiple times within a r600_pipe_state struct. > Is this supposed to fix anything in particular? The patch makes sense to me as an optimization, but if it changes behaviour that w

[Mesa-dev] [PATCH] r600g: Avoid setting one gpu register multiple times in a r600_pipe_state

2011-03-12 Thread Mathias Fröhlich
Hi, Attached is a patch to the r600g driver that avoids setting one specific gpu register multiple times within a r600_pipe_state struct. Please review and may be apply Thanks! Mathias From 704b858158fd420be6cf810425f04371e796b883 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathias=20Fr=C3=B6hli