Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

2013-06-30 Thread Marek Olšák
FYI, I have applied the patch to my local branch and added a few more fixes. I'll send it once I finish some other things I'm working on right now. Marek On Sun, Jun 23, 2013 at 11:56 PM, Alex Deucher wrote: > On Sun, Jun 23, 2013 at 2:24 PM, Marek Olšák wrote: >> Hi Alex, >> >> rctx->framebuff

Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

2013-06-24 Thread Tom Stellard
On Sun, Jun 23, 2013 at 05:56:15PM -0400, Alex Deucher wrote: > On Sun, Jun 23, 2013 at 2:24 PM, Marek Olšák wrote: > > Hi Alex, > > > > rctx->framebuffer.state.nr_cbufs might not contain what you think it > > does, because the framebuffer that needs flushing may have been > > replaced by a new fr

Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

2013-06-23 Thread Martin Andersson
On Sun, Jun 23, 2013 at 11:56 PM, Alex Deucher wrote: > On Sun, Jun 23, 2013 at 2:24 PM, Marek Olšák wrote: >> Hi Alex, >> >> rctx->framebuffer.state.nr_cbufs might not contain what you think it >> does, because the framebuffer that needs flushing may have been >> replaced by a new framebuffer an

Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

2013-06-23 Thread Alex Deucher
On Sun, Jun 23, 2013 at 2:24 PM, Marek Olšák wrote: > Hi Alex, > > rctx->framebuffer.state.nr_cbufs might not contain what you think it > does, because the framebuffer that needs flushing may have been > replaced by a new framebuffer and the cache flushing of the old > framebuffer usually takes pl

Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

2013-06-23 Thread Martin Andersson
On Sun, Jun 23, 2013 at 7:41 PM, Alex Deucher wrote: > On Sat, Jun 22, 2013 at 11:53 AM, Martin Andersson wrote: >> On Sat, Jun 22, 2013 at 12:22 PM, Marek Olšák wrote: >>> Reviewed-by: Marek Olšák >>> >>> BTW, SMX is a write cache, to maybe it shouldn't be part of this patch. >> >> I made a li

Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

2013-06-23 Thread Marek Olšák
Hi Alex, rctx->framebuffer.state.nr_cbufs might not contain what you think it does, because the framebuffer that needs flushing may have been replaced by a new framebuffer and the cache flushing of the old framebuffer usually takes place before the first draw to the new framebuffer. To solve this,

Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

2013-06-23 Thread Alex Deucher
On Sat, Jun 22, 2013 at 11:53 AM, Martin Andersson wrote: > On Sat, Jun 22, 2013 at 12:22 PM, Marek Olšák wrote: >> Reviewed-by: Marek Olšák >> >> BTW, SMX is a write cache, to maybe it shouldn't be part of this patch. > > I made a little experiment where i ran > "ext_framebuffer_multisample-una

Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

2013-06-22 Thread Martin Andersson
On Sat, Jun 22, 2013 at 12:22 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > BTW, SMX is a write cache, to maybe it shouldn't be part of this patch. I made a little experiment where i ran "ext_framebuffer_multisample-unaligned-blit 4 color downsample -auto" 1 times and found that with

Re: [Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

2013-06-22 Thread Marek Olšák
Reviewed-by: Marek Olšák BTW, SMX is a write cache, to maybe it shouldn't be part of this patch. Marek On Sun, Jun 16, 2013 at 1:27 PM, Martin Andersson wrote: > Not including the SH and SMX caches when invalidating read caches causes > random failures on some piglit tests when VA is enabled.

[Mesa-dev] [PATCH] r600g: Include SH and SMX when invalidating read caches

2013-06-16 Thread Martin Andersson
Not including the SH and SMX caches when invalidating read caches causes random failures on some piglit tests when VA is enabled. Since the failures are random, and there other problems also causing random failures, it's hard to know exactly what tests were effected, but these tests now consistent