Re: [Mesa-dev] [PATCH] r600g: Various patches

2011-06-14 Thread Mathias Fröhlich
On Monday, June 13, 2011 17:55:35 Alex Deucher wrote: > These first 4 look good to me. I've done a piglit run with them and > no regressions. I've gone ahead and applied them. Thanks! Mathias ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

Re: [Mesa-dev] [PATCH] r600g: Various patches

2011-06-13 Thread Alex Deucher
2011/6/12 Mathias Fröhlich : > > Hi, > > attached is a set of patches to r600g. > > 0001-r600g-Fix-typo.patch: > Fix a more or less obvious typo in shader initialization setup. > > 0002-r600g-Set-the-domains-value-also-for-recycled-buffer.patch: > Makes sure that buffer objects from the userspace b

Re: [Mesa-dev] [PATCH] r600g: Various patches

2011-06-12 Thread Mathias Fröhlich
Good Morning, On Monday, June 13, 2011 00:39:51 Marek Olšák wrote: > 2011/6/12 Mathias Fröhlich : > > There is the implementation of glBufferData which detaches itself from > > the underlying pipe_resource by unreferencing the old one and creating a > > new one. > > I was looking into this issue

Re: [Mesa-dev] [PATCH] r600g: Various patches

2011-06-12 Thread Marek Olšák
2011/6/12 Mathias Fröhlich : > There is the implementation of glBufferData which detaches itself from the > underlying pipe_resource by unreferencing the old one and creating a new one. I was looking into this issue and realized glBufferData is a special case, it adds the _NEW_BUFFER_OBJECT flag t

Re: [Mesa-dev] [PATCH] r600g: Various patches

2011-06-12 Thread Marek Olšák
2011/6/12 Mathias Fröhlich : > On Sunday, June 12, 2011 16:53:08 Marek Olšák wrote: >> 2011/6/12 Mathias Fröhlich : >> > 0005-r600g-Make-use-of-PIPE_TRANSFER_DISCARD_WHOLE_RESOUR.patch: >> > This makes use of the DISCARD_WHOLE_RESOURCE flag for memory mappings. >> >> That won't work. The old buffer

Re: [Mesa-dev] [PATCH] r600g: Various patches

2011-06-12 Thread Mathias Fröhlich
On Sunday, June 12, 2011 16:53:08 Marek Olšák wrote: > 2011/6/12 Mathias Fröhlich : > > 0005-r600g-Make-use-of-PIPE_TRANSFER_DISCARD_WHOLE_RESOUR.patch: > > This makes use of the DISCARD_WHOLE_RESOURCE flag for memory mappings. > > That won't work. The old buffer may still be set as a vertex > buf

Re: [Mesa-dev] [PATCH] r600g: Various patches

2011-06-12 Thread Marek Olšák
2011/6/12 Mathias Fröhlich : > 0005-r600g-Make-use-of-PIPE_TRANSFER_DISCARD_WHOLE_RESOUR.patch: > This makes use of the DISCARD_WHOLE_RESOURCE flag for memory mappings. That won't work. The old buffer may still be set as a vertex buffer/texture. If you replace the whole buffer like that, all the s

[Mesa-dev] [PATCH] r600g: Various patches

2011-06-12 Thread Mathias Fröhlich
Hi, attached is a set of patches to r600g. 0001-r600g-Fix-typo.patch: Fix a more or less obvious typo in shader initialization setup. 0002-r600g-Set-the-domains-value-also-for-recycled-buffer.patch: Makes sure that buffer objects from the userspace bo manager does not have a degraded domains v