Re: [Mesa-dev] [PATCH] r600g: fix crash in set_framebuffer_state

2013-10-11 Thread Marek Olšák
Pushed, thanks. Marek On Fri, Oct 11, 2013 at 1:23 AM, Grigori Goronzy g...@chown.ath.cx wrote: We should be able to safely set the framebuffer state without a fragment shader bound. bind_ps_state will take care of updating the necessary state bits later. v2: check in

[Mesa-dev] [PATCH] r600g: fix crash in set_framebuffer_state

2013-10-10 Thread Grigori Goronzy
We should be able to safely set the framebuffer state without a fragment shader bound. bind_ps_state will take care of updating the necessary state bits later. --- src/gallium/drivers/r600/evergreen_state.c | 4 +++- src/gallium/drivers/r600/r600_state.c | 4 +++- 2 files changed, 6

Re: [Mesa-dev] [PATCH] r600g: fix crash in set_framebuffer_state

2013-10-10 Thread Marek Olšák
It would be safer to check ps_shader in update_db_shader_control instead. This is not the only place where update_db_shader_control is called. Marek On Thu, Oct 10, 2013 at 7:17 PM, Grigori Goronzy g...@chown.ath.cx wrote: We should be able to safely set the framebuffer state without a

[Mesa-dev] [PATCH] r600g: fix crash in set_framebuffer_state

2013-10-10 Thread Grigori Goronzy
We should be able to safely set the framebuffer state without a fragment shader bound. bind_ps_state will take care of updating the necessary state bits later. v2: check in update_db_shader_control --- src/gallium/drivers/r600/evergreen_state.c | 23 +++