Re: [Mesa-dev] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-03-21 Thread Leo Liu
On 03/21/2018 10:25 AM, Christian König wrote: Can't 100% judge if that is correct, but on first glance it seems to make sense. It all depends on how firmware handle it. The only thing we could do is to verify on different generation of HW as much as possible. Thanks, Leo Patch is Acked-

Re: [Mesa-dev] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-03-21 Thread Christian König
Can't 100% judge if that is correct, but on first glance it seems to make sense. Patch is Acked-by: Christian König . Regards, Christian. Am 21.03.2018 um 15:22 schrieb Leo Liu: Ping. On 03/19/2018 01:11 PM, Leo Liu wrote: On the CI family, firmware requires the destory command have to be

Re: [Mesa-dev] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-03-21 Thread Leo Liu
Ping. On 03/19/2018 01:11 PM, Leo Liu wrote: On the CI family, firmware requires the destory command have to be the last command in the IB, moving feedback command after destroy is causing issues on CI cards, so we have to keep the previous logic that moves destroy back to the last command. Bu

[Mesa-dev] [PATCH] radeon/vce: move feedback command inside of destroy function

2018-03-19 Thread Leo Liu
On the CI family, firmware requires the destory command have to be the last command in the IB, moving feedback command after destroy is causing issues on CI cards, so we have to keep the previous logic that moves destroy back to the last command. But as the original issue fixed previously, with th