Re: [Mesa-dev] [PATCH] radeonsi: Simplify si_dma_copy_tile function

2014-09-11 Thread Michel Dänzer
On 11.09.2014 00:28, Grigori Goronzy wrote: On 10.09.2014 10:54, Michel Dänzer wrote: From: Michel Dänzer + array_mode = si_array_mode(rtiled->surface.level[tiled_lvl].mode); Wouldn't it be more consistent to pull the array_mode from the tile mode array like other parameters? I don't

Re: [Mesa-dev] [PATCH] radeonsi: Simplify si_dma_copy_tile function

2014-09-10 Thread Grigori Goronzy
LGTM, but I have a comments below. Grigori On 10.09.2014 10:54, Michel Dänzer wrote: > From: Michel Dänzer > > Signed-off-by: Michel Dänzer > --- > > This might help for investigating DMA related bugs. > > src/gallium/drivers/radeonsi/si_dma.c | 103 > ++ >

Re: [Mesa-dev] [PATCH] radeonsi: Simplify si_dma_copy_tile function

2014-09-10 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Sep 10, 2014 at 10:54 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Signed-off-by: Michel Dänzer > --- > > This might help for investigating DMA related bugs. > > src/gallium/drivers/radeonsi/si_dma.c | 103 > ++ >

[Mesa-dev] [PATCH] radeonsi: Simplify si_dma_copy_tile function

2014-09-10 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- This might help for investigating DMA related bugs. src/gallium/drivers/radeonsi/si_dma.c | 103 ++ 1 file changed, 41 insertions(+), 62 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_dma.c b/src