Re: [Mesa-dev] [PATCH] radeonsi: don't set DATA_FORMAT if ADD_TID_ENABLE is set on VI (v2)

2015-10-02 Thread Marek Olšák
After some testing, I realized this patch causes problems. DATA_FORMAT with ADD_TID=1 means STRIDE[14:17] only if the instruction is untyped MUBUF, but Mesa only uses ADD_TID with typed MUBUF (tbuffer in particular). Marek On Thu, Oct 1, 2015 at 10:27 AM, Christian König wrote: > On 01.10.2015 0

Re: [Mesa-dev] [PATCH] radeonsi: don't set DATA_FORMAT if ADD_TID_ENABLE is set on VI (v2)

2015-10-01 Thread Christian König
On 01.10.2015 05:44, Michel Dänzer wrote: On 01.10.2015 04:11, Marek Olšák wrote: From: Marek Olšák This can cause incorrect address calculations and hangs. v2: do it properly Cc: mesa-sta...@lists.freedesktop.org Tested-and-Reviewed-by: Christian König --- src/gallium/drivers/radeonsi/si

Re: [Mesa-dev] [PATCH] radeonsi: don't set DATA_FORMAT if ADD_TID_ENABLE is set on VI (v2)

2015-09-30 Thread Michel Dänzer
On 01.10.2015 04:11, Marek Olšák wrote: > From: Marek Olšák > > This can cause incorrect address calculations and hangs. > > v2: do it properly > > Cc: mesa-sta...@lists.freedesktop.org > Tested-and-Reviewed-by: Christian König > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 9 +++

[Mesa-dev] [PATCH] radeonsi: don't set DATA_FORMAT if ADD_TID_ENABLE is set on VI (v2)

2015-09-30 Thread Marek Olšák
From: Marek Olšák This can cause incorrect address calculations and hangs. v2: do it properly Cc: mesa-sta...@lists.freedesktop.org Tested-and-Reviewed-by: Christian König --- src/gallium/drivers/radeonsi/si_descriptors.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --g