Re: [Mesa-dev] [PATCH] radv: Disable primitive restart for non-indexed draws

2017-04-12 Thread Alex Smith
Good point, I'll fix that up and send a v2. Thanks, Alex On 11 April 2017 at 21:34, Bas Nieuwenhuizen wrote: > So I think we need to reset both command buffer states (the enable and > the index) when we call a secondary command buffer. > > With that fixed, this patch

Re: [Mesa-dev] [PATCH] radv: Disable primitive restart for non-indexed draws

2017-04-11 Thread Bas Nieuwenhuizen
So I think we need to reset both command buffer states (the enable and the index) when we call a secondary command buffer. With that fixed, this patch is Reviewed-by: Bas Nieuwenhuizen On Tue, Apr 11, 2017 at 3:30 PM, Alex Smith wrote: >

[Mesa-dev] [PATCH] radv: Disable primitive restart for non-indexed draws

2017-04-11 Thread Alex Smith
According to the Vulkan spec, VkPipelineInputAssemblyStateCreateInfo's primitiveRestartEnable flag should only apply to indexed draws, however it was being enabled regardless of the type of draw. This could cause problems for non-indexed draws with >=65535 vertices if the previous indexed draw