Re: [Mesa-dev] [PATCH] radv: add support for layered clears (v2)

2017-01-16 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Jan 17, 2017 at 1:07 AM, Dave Airlie wrote: > From: Dave Airlie > > Just always use the layer clear pipelines, > the overhead of emitting the layer shouldn't be > too large. > > v2: Bas suggested we always use it. > > Signed-off-by: Dave Airlie > --- > s

[Mesa-dev] [PATCH] radv: add support for layered clears (v2)

2017-01-16 Thread Dave Airlie
From: Dave Airlie Just always use the layer clear pipelines, the overhead of emitting the layer shouldn't be too large. v2: Bas suggested we always use it. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_clear.c | 28 ++-- 1 file changed, 22 insertions(+), 6 de

Re: [Mesa-dev] [PATCH] radv: add support for layered clears

2017-01-16 Thread Bas Nieuwenhuizen
Looks correct to me, but why don't we always use the layered clear? I'd think the extra VS output doesn't really matter given the low amount of geometry during clearing, and that would save some shader variants, which we have a lot of already. - Bas On Mon, Jan 16, 2017 at 11:58 PM, Dave Airlie

[Mesa-dev] [PATCH] radv: add support for layered clears

2017-01-16 Thread Dave Airlie
From: Dave Airlie This uses vertex layer from instance id to clear the layers. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_clear.c | 150 --- src/amd/vulkan/radv_private.h| 12 ++-- 2 files changed, 102 insertions(+), 60 deletions(-) diff -