Re: [Mesa-dev] [PATCH] radv: lower constant initializers on output variables earlier

2018-03-19 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 03/19/2018 05:30 AM, Dave Airlie wrote: From: Dave Airlie If a shader only writes to an output via a constant initializer we need to lower it before we call nir_remove_dead_variables so that this pass sees the stores from the initializer and doesn't kill the ou

Re: [Mesa-dev] [PATCH] radv: lower constant initializers on output variables earlier

2018-03-19 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Mar 19, 2018 at 5:30 AM, Dave Airlie wrote: > From: Dave Airlie > > If a shader only writes to an output via a constant initializer we > need to lower it before we call nir_remove_dead_variables so that > this pass sees the stores from the initializer and

[Mesa-dev] [PATCH] radv: lower constant initializers on output variables earlier

2018-03-18 Thread Dave Airlie
From: Dave Airlie If a shader only writes to an output via a constant initializer we need to lower it before we call nir_remove_dead_variables so that this pass sees the stores from the initializer and doesn't kill the output. Fixes test failures in new work-in-progress CTS tests: dEQP-VK.spirv_