Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

2017-06-20 Thread Dave Airlie
On 21 June 2017 at 08:11, Grazvydas Ignotas wrote: > On Tue, Jun 20, 2017 at 7:11 PM, Jason Ekstrand wrote: >> Doom shipped with a broken version of GLSLang which handles samplers as >> function arguments in a way that isn't spec-compliant. In particular, >> it creates a temporary local sampler

Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

2017-06-20 Thread Grazvydas Ignotas
On Tue, Jun 20, 2017 at 7:11 PM, Jason Ekstrand wrote: > Doom shipped with a broken version of GLSLang which handles samplers as > function arguments in a way that isn't spec-compliant. In particular, > it creates a temporary local sampler variable and copies the sampler > into it. While Dave ha

Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

2017-06-20 Thread Jason Ekstrand
On Tue, Jun 20, 2017 at 12:19 PM, Pierre-Loup A. Griffais < pgriff...@valvesoftware.com> wrote: > They gave us access to a build with the fix and I believe Dave confirmed > the fix was looking good by running it against a mainline build of radv. I > can't comment on what their planned timeline is

Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

2017-06-20 Thread Pierre-Loup A. Griffais
They gave us access to a build with the fix and I believe Dave confirmed the fix was looking good by running it against a mainline build of radv. I can't comment on what their planned timeline is for releasing it or whether it's going to be released for sure, but it seems that title is going to

Re: [Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

2017-06-20 Thread Connor Abbott
I've been told by Pierre that there is an update, but it just hasn't been pushed out yet. He'd know better when it's supposed to be released. On Tue, Jun 20, 2017 at 9:11 AM, Jason Ekstrand wrote: > Doom shipped with a broken version of GLSLang which handles samplers as > function arguments in a

[Mesa-dev] [PATCH] spirv: Work around the Doom shader bug

2017-06-20 Thread Jason Ekstrand
Doom shipped with a broken version of GLSLang which handles samplers as function arguments in a way that isn't spec-compliant. In particular, it creates a temporary local sampler variable and copies the sampler into it. While Dave has had a hack patch out for a while that gets it working, we've n