Re: [Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-18 Thread Jose Fonseca
- Original Message - > On Tue, Jan 17, 2012 at 15:47, Stéphane Marchesin > wrote: > > On Wed, Jan 11, 2012 at 10:13, Jose Fonseca > > wrote: > >> - Original Message - > >>> Where else would the flush go? > >> > >> Maybe one of the callers already invoked glFlush, or something >

Re: [Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-17 Thread Stéphane Marchesin
On Tue, Jan 17, 2012 at 15:47, Stéphane Marchesin wrote: > On Wed, Jan 11, 2012 at 10:13, Jose Fonseca wrote: >> - Original Message - >>> Where else would the flush go? >> >> Maybe one of the callers already invoked glFlush, or something like that. >> >>> I'll look into fixing it differen

Re: [Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-17 Thread Stéphane Marchesin
On Wed, Jan 11, 2012 at 10:13, Jose Fonseca wrote: > - Original Message - >> Where else would the flush go? > > Maybe one of the callers already invoked glFlush, or something like that. > >> I'll look into fixing it differently >> but if the flush is anywhere in the makecurrent path, the s

Re: [Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-12 Thread Jose Fonseca
- Original Message - > On Wed, Jan 11, 2012 at 10:13, Jose Fonseca > wrote: > > - Original Message - > >> Where else would the flush go? > > > > Maybe one of the callers already invoked glFlush, or something like > > that. > > > > Not that I could see. > > >> I'll look into fix

Re: [Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-11 Thread Stéphane Marchesin
On Wed, Jan 11, 2012 at 10:13, Jose Fonseca wrote: > - Original Message - >> Where else would the flush go? > > Maybe one of the callers already invoked glFlush, or something like that. > Not that I could see. >> I'll look into fixing it differently >> but if the flush is anywhere in the

Re: [Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-11 Thread Jose Fonseca
- Original Message - > Where else would the flush go? Maybe one of the callers already invoked glFlush, or something like that. > I'll look into fixing it differently > but if the flush is anywhere in the makecurrent path, the same issue > will happen. Again, none of the classic dri driv

Re: [Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-11 Thread Jakob Bornecrantz
Are you sure that the flush doesn't happen somewhere higher up in the call chain, like in the common dri code, or glx code? Cheers, Jakob. - Ursprungligt meddelande - > Where else would the flush go? I'll look into fixing it differently > but if the flush is anywhere in the makecurrent pa

Re: [Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-11 Thread Stéphane Marchesin
Where else would the flush go? I'll look into fixing it differently but if the flush is anywhere in the makecurrent path, the same issue will happen. Again, none of the classic dri drivers do it. Stéphane 2012/1/11 Jose Fonseca : > Stephane, > > Although flushing the front buffer may be unnecess

Re: [Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-11 Thread Jose Fonseca
Stephane, Although flushing the front buffer may be unnecessary, flushing itself is not, as glXMakeCurrent mandates that the current must be flushed: "Pending commands to the previous context, if any, are flushed before it is released." So this flush call can only be removed, if a flush is

[Mesa-dev] [PATCH] st/dri: Remove useless flush front.

2012-01-10 Thread Stéphane Marchesin
In the following scenario: - CreateContext C1 - MakeCurrent C1 - DestroyContext C1 (does not actually destroy the first context, postponed until the next MakeCurrent) - CreateContext C2 - MakeCurrent C2 MakeCurrent will call flush on a context which might not even have had a front buffer, leadin