Re: [Mesa-dev] [PATCH] st/glsl_to_nir: add more nir opts to st_nir_opts()

2018-01-31 Thread Eric Anholt
Timothy Arceri writes: > All of the current gallium nir driver use these optimisations but > they do so in their backends. Having these called in the backend > only can cause a number of problems: > > - Shader compile times are greater because the opts need to do >

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: add more nir opts to st_nir_opts()

2018-01-31 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jan 31, 2018 at 3:00 AM, Timothy Arceri wrote: > I forgot to add that adding the opts also required some of the lowering > passes to be called slightly earlier. > > > On 31/01/18 12:58, Timothy Arceri wrote: >>

Re: [Mesa-dev] [PATCH] st/glsl_to_nir: add more nir opts to st_nir_opts()

2018-01-30 Thread Timothy Arceri
I forgot to add that adding the opts also required some of the lowering passes to be called slightly earlier. On 31/01/18 12:58, Timothy Arceri wrote: All of the current gallium nir driver use these optimisations but they do so in their backends. Having these called in the backend only can

[Mesa-dev] [PATCH] st/glsl_to_nir: add more nir opts to st_nir_opts()

2018-01-30 Thread Timothy Arceri
All of the current gallium nir driver use these optimisations but they do so in their backends. Having these called in the backend only can cause a number of problems: - Shader compile times are greater because the opts need to do significant passes over all shader variants. - The shader cache