Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

2014-08-07 Thread Roland Scheidegger
Ah right. That's why it didn't matter then :-) Roland Am 08.08.2014 02:30, schrieb Marek Olšák: > Hi Roland, > > This code isn't used by llvmpipe, because it returns > PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER = 0. > > Marek > > On Fri, Aug 8, 2014 at 1:33 AM, Roland Scheidegger wrote: >> L

Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

2014-08-07 Thread Marek Olšák
Hi Roland, This code isn't used by llvmpipe, because it returns PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER = 0. Marek On Fri, Aug 8, 2014 at 1:33 AM, Roland Scheidegger wrote: > Looks good to me too. I guess on llvmpipe we got lucky because > row_stride and layer_stride were equal so the math

Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

2014-08-07 Thread Roland Scheidegger
Looks good to me too. I guess on llvmpipe we got lucky because row_stride and layer_stride were equal so the math worked out the same in the end :-). Reviewed-by: Roland Scheidegger Am 08.08.2014 01:18, schrieb Ilia Mirkin: > Reviewed-by: Ilia Mirkin > > Makes sense and also fixes the new pigl

Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

2014-08-07 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin Makes sense and also fixes the new piglit on nvc0. On Thu, Aug 7, 2014 at 6:49 PM, Marek Olšák wrote: > From: Marek Olšák > > This fixes piglit spec/EXT_texture_array/render-1darray. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/mesa/state_tracker/st_cb_textur

[Mesa-dev] [PATCH] st/mesa: fix blit-based partial TexSubImage for 1D arrays

2014-08-07 Thread Marek Olšák
From: Marek Olšák This fixes piglit spec/EXT_texture_array/render-1darray. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/st_cb_texture.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c inde