In the past, when we called pipe::set_sampler_views(n) the drivers set
samplers [n..MAX] to NULL. We no longer do that. The state tracker
code was already trying to set unused sampler views to NULL to cover
that case, but the logic was broken and unnoticed until now. This patch
fixes it.
Fixes
This looks good, but I don't see how it could fix anything.
Bound-but-unused sampler views should have no effect on rendering.
Marek
On Fri, Aug 17, 2012 at 4:28 PM, Brian Paul wrote:
> In the past, when we called pipe::set_sampler_views(n) the drivers set
> samplers [n..MAX] to NULL. We no lon
The bug in question was happening because when all texturing got
turned off we were calling pipe->set_sampler_views(count=0). In
llvmpipe this caused the function to return early, before we set the
LP_NEW_SAMPLER_VIEW flag. That caused us to miss some state validation.
I agree that unused sa
