Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-12 Thread Brian Paul
On 04/12/2016 04:56 AM, Emil Velikov wrote: Hi Brian, I can see that the fix is in, so just a question for posterity. On 11 April 2016 at 23:39, Brian Paul wrote: Instead of using an array indexed by SYSTEM_VALUE_x, just use a switch statement. This fixes a regression

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-12 Thread Emil Velikov
Hi Brian, I can see that the fix is in, so just a question for posterity. On 11 April 2016 at 23:39, Brian Paul wrote: > Instead of using an array indexed by SYSTEM_VALUE_x, just use a > switch statement. This fixes a regression caused by inserting new > SYSTEM_VALUE_ enums

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-12 Thread Marek Olšák
On Tue, Apr 12, 2016 at 3:22 AM, Roland Scheidegger wrote: > Am 12.04.2016 um 02:04 schrieb Jason Ekstrand: >> >> >> On Mon, Apr 11, 2016 at 4:31 PM, Roland Scheidegger > > wrote: >> >> Am 12.04.2016 um 00:39 schrieb Brian

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-12 Thread Jose Fonseca
On 11/04/16 23:39, Brian Paul wrote: Instead of using an array indexed by SYSTEM_VALUE_x, just use a switch statement. This fixes a regression caused by inserting new SYSTEM_VALUE_ enums but not updating the mapping to TGSI semantics. v2: fix a few switch statement mistakes for compute-related

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-11 Thread Roland Scheidegger
Am 12.04.2016 um 02:04 schrieb Jason Ekstrand: > > > On Mon, Apr 11, 2016 at 4:31 PM, Roland Scheidegger > wrote: > > Am 12.04.2016 um 00:39 schrieb Brian Paul: > > Instead of using an array indexed by SYSTEM_VALUE_x, just use a > >

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-11 Thread Jason Ekstrand
On Mon, Apr 11, 2016 at 4:31 PM, Roland Scheidegger wrote: > Am 12.04.2016 um 00:39 schrieb Brian Paul: > > Instead of using an array indexed by SYSTEM_VALUE_x, just use a > > switch statement. This fixes a regression caused by inserting new > > SYSTEM_VALUE_ enums but not

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-11 Thread Roland Scheidegger
Am 12.04.2016 um 00:39 schrieb Brian Paul: > Instead of using an array indexed by SYSTEM_VALUE_x, just use a > switch statement. This fixes a regression caused by inserting new > SYSTEM_VALUE_ enums but not updating the mapping to TGSI semantics. > > v2: fix a few switch statement mistakes for

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-11 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, Apr 11, 2016 at 6:39 PM, Brian Paul wrote: > Instead of using an array indexed by SYSTEM_VALUE_x, just use a > switch statement. This fixes a regression caused by inserting new > SYSTEM_VALUE_ enums but not updating the

[Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-11 Thread Brian Paul
Instead of using an array indexed by SYSTEM_VALUE_x, just use a switch statement. This fixes a regression caused by inserting new SYSTEM_VALUE_ enums but not updating the mapping to TGSI semantics. v2: fix a few switch statement mistakes for compute-related enums ---

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-11 Thread Roland Scheidegger
Am 12.04.2016 um 00:30 schrieb Brian Paul: > Instead of using an array indexed by SYSTEM_VALUE_x, just use a > switch statement. This fixes a regression caused by inserting new > SYSTEM_VALUE_ enums but not updating the mapping to TGSI semantics. > --- >

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-11 Thread Ilia Mirkin
On Mon, Apr 11, 2016 at 6:30 PM, Brian Paul wrote: > Instead of using an array indexed by SYSTEM_VALUE_x, just use a > switch statement. This fixes a regression caused by inserting new > SYSTEM_VALUE_ enums but not updating the mapping to TGSI semantics. > --- >

Re: [Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-11 Thread Brian Paul
On 04/11/2016 04:30 PM, Brian Paul wrote: Instead of using an array indexed by SYSTEM_VALUE_x, just use a switch statement. This fixes a regression caused by inserting new SYSTEM_VALUE_ enums but not updating the mapping to TGSI semantics. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 132

[Mesa-dev] [PATCH] st/mesa: replace _mesa_sysval_to_semantic table with function

2016-04-11 Thread Brian Paul
Instead of using an array indexed by SYSTEM_VALUE_x, just use a switch statement. This fixes a regression caused by inserting new SYSTEM_VALUE_ enums but not updating the mapping to TGSI semantics. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 132 ++---