Re: [Mesa-dev] [PATCH] st/mesa: use a single memcpy in st_ReadPixels when possible

Hi, FYI, piglit "mesa_pack_invert-readpixels -auto -fbo" crashes with this commit. Marek On Tue, Jun 21, 2016 at 11:08 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This avoids costly address recomputations, function overhead, and may trigger > large copy optimizations. > --- > src/mes

Re: [Mesa-dev] [PATCH] st/mesa: use a single memcpy in st_ReadPixels when possible

Reviewed-by: Marek Olšák Marek On Tue, Jun 21, 2016 at 11:08 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This avoids costly address recomputations, function overhead, and may trigger > large copy optimizations. > --- > src/mesa/state_tracker/st_cb_readpixels.c | 23 +++---

Re: [Mesa-dev] [PATCH] st/mesa: use a single memcpy in st_ReadPixels when possible

On 06/21/2016 03:08 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle This avoids costly address recomputations, function overhead, and may trigger large copy optimizations. --- src/mesa/state_tracker/st_cb_readpixels.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions

[Mesa-dev] [PATCH] st/mesa: use a single memcpy in st_ReadPixels when possible

From: Nicolai Hähnle This avoids costly address recomputations, function overhead, and may trigger large copy optimizations. --- src/mesa/state_tracker/st_cb_readpixels.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_rea