Re: [Mesa-dev] [PATCH] st/mesa: use surface format to generate mipmaps when available

2016-01-14 Thread Ilia Mirkin
H well I set ->surface_based = TRUE on texture views. It seemed to correspond to the restrictions of surface-based elsewhere, but I probably wasn't 100% sure what the deal was back when I added the logic. On Thu, Jan 14, 2016 at 2:38 PM, Marek Olšák wrote: > Hi Ilia, > > surface_based ori

Re: [Mesa-dev] [PATCH] st/mesa: use surface format to generate mipmaps when available

2016-01-14 Thread Marek Olšák
Hi Ilia, surface_based originally meant that the resource has been imported from a DMABUF or GEM FLINK handle. Such resources can't be reallocated ever, nor can they be mipmapped. Marek On Thu, Jan 14, 2016 at 7:46 PM, Ilia Mirkin wrote: > This fixes the recently posted mipmap + texture views p

Re: [Mesa-dev] [PATCH] st/mesa: use surface format to generate mipmaps when available

2016-01-14 Thread Roland Scheidegger
Looks good to me. Reviewed-by: Roland Scheidegger Am 14.01.2016 um 19:46 schrieb Ilia Mirkin: > This fixes the recently posted mipmap + texture views piglit test. > > Signed-off-by: Ilia Mirkin > Cc: "11.0 11.1" > --- > src/mesa/state_tracker/st_gen_mipmap.c | 10 -- > 1 file changed

[Mesa-dev] [PATCH] st/mesa: use surface format to generate mipmaps when available

2016-01-14 Thread Ilia Mirkin
This fixes the recently posted mipmap + texture views piglit test. Signed-off-by: Ilia Mirkin Cc: "11.0 11.1" --- src/mesa/state_tracker/st_gen_mipmap.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_gen_mipmap.c b/src/mesa/state_tracke