Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-15 Thread Nicolai Hähnle
On 15.11.2017 12:30, Jon Turney wrote: On 15/11/2017 11:21, Nicolai Hähnle wrote: On 13.11.2017 23:55, Rob Herring wrote: On Fri, Nov 10, 2017 at 12:39 PM, Jon Turney wrote: On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähn

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-15 Thread Jon Turney
On 15/11/2017 11:21, Nicolai Hähnle wrote: On 13.11.2017 23:55, Rob Herring wrote: On Fri, Nov 10, 2017 at 12:39 PM, Jon Turney wrote: On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm g

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-15 Thread Nicolai Hähnle
On 13.11.2017 23:55, Rob Herring wrote: On Fri, Nov 10, 2017 at 12:39 PM, Jon Turney wrote: On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to suggest that the fallback declaratio

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-13 Thread Rob Herring
On Fri, Nov 10, 2017 at 12:39 PM, Jon Turney wrote: > On 10/11/2017 15:42, Nicolai Hähnle wrote: >> >> On 10.11.2017 14:00, Jon Turney wrote: >>> >>> On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. >>> >>> >>> I'm going to suggest that the fallback declaration of timespec_

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-10 Thread Jon Turney
On 10/11/2017 15:42, Nicolai Hähnle wrote: On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to suggest that the fallback declaration of timespec_get() also needs to be provided for POSIX systems which don't have it. Not noticed

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-10 Thread Nicolai Hähnle
On 10.11.2017 14:00, Jon Turney wrote: On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to suggest that the fallback declaration of timespec_get() also needs to be provided for POSIX systems which don't have it. Not noticed previously as it (or xtime_get()) doesn't s

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-10 Thread Jon Turney
On 09/11/2017 21:41, Nicolai Hähnle wrote: Sorry for the mess. I'm going to suggest that the fallback declaration of timespec_get() also needs to be provided for POSIX systems which don't have it. Not noticed previously as it (or xtime_get()) doesn't seem to have had any users, prior to thi

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-09 Thread Roland Scheidegger
FWIW it looks like this series also broke compilation on mac os (I suppose that was f0d3a4de75fdb865c058aba8614f0fe6ba5f0969 though): [...truncated 173 lines...] pthread_barrier_destroy(barrier); ^~~ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.plat

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-09 Thread Brian Paul
On 11/09/2017 02:41 PM, Nicolai Hähnle wrote: Sorry for the mess. Not a huge deal. FWIW, you can test the MinGW cross-compile pretty easily: 1. apt-get install g++-mingw-w64-x86-64 (or equivalent) 2. cd mesa ; scons platform=windows -Brian Reviewed-by: Nicolai Hähnle On 09.11.2017 17:46

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-09 Thread Nicolai Hähnle
Sorry for the mess. Reviewed-by: Nicolai Hähnle On 09.11.2017 17:46, Brian Paul wrote: Fixes: f1a364878431c8 ("threads: update for late C11 changes") --- include/c11/threads_win32.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/c11/threads_win32.h b/include

Re: [Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-09 Thread Roland Scheidegger
Looks alright to me. Reviewed-by: Roland Scheidegger Am 09.11.2017 um 17:46 schrieb Brian Paul: > Fixes: f1a364878431c8 ("threads: update for late C11 changes") > --- > include/c11/threads_win32.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/c11/threads_

[Mesa-dev] [PATCH] threads: fix MinGW build breakage

2017-11-09 Thread Brian Paul
Fixes: f1a364878431c8 ("threads: update for late C11 changes") --- include/c11/threads_win32.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/c11/threads_win32.h b/include/c11/threads_win32.h index 77d923a..dac8ef7 100644 --- a/include/c11/threads_win32.h +++ b/inc