Re: [Mesa-dev] [PATCH] util: Use LONG_MAX instead of LONG_BIT.

2015-08-09 Thread Jose Fonseca
On 09/08/15 23:30, Matt Turner wrote: On Sun, Aug 9, 2015 at 2:40 PM, Jose Fonseca wrote: More portable. Based on Roland Scheidegger's idea. Tested with roundevent_test on Linux, MinGW, and MSVC. https://bugs.freedesktop.org/show_bug.cgi?id=91591 --- src/util/rounding.h | 15 +++---

Re: [Mesa-dev] [PATCH] util: Use LONG_MAX instead of LONG_BIT.

2015-08-09 Thread Matt Turner
On Sun, Aug 9, 2015 at 2:40 PM, Jose Fonseca wrote: > More portable. Based on Roland Scheidegger's idea. > > Tested with roundevent_test on Linux, MinGW, and MSVC. > > https://bugs.freedesktop.org/show_bug.cgi?id=91591 > --- > src/util/rounding.h | 15 +++ > 1 file changed, 11 insert

Re: [Mesa-dev] [PATCH] util: Use LONG_MAX instead of LONG_BIT.

2015-08-09 Thread Jose Fonseca
Indeed, given these are Mesa internal functions, we could indeed have then return int32 or int64 and side-step this problem completely. Especially because the callers of these function might care about those things too. Nothing prevents we do that in the medium term, but in the short term th

Re: [Mesa-dev] [PATCH] util: Use LONG_MAX instead of LONG_BIT.

2015-08-09 Thread Roland Scheidegger
Looks good to me. Would have been much less trouble if we'd just returned an int, to hell with lrintf's long return type no callers will care about the long returned anyway... Reviewed-by: Roland Scheidegger Am 09.08.2015 um 23:40 schrieb Jose Fonseca: > More portable. Based on Roland Scheideg

[Mesa-dev] [PATCH] util: Use LONG_MAX instead of LONG_BIT.

2015-08-09 Thread Jose Fonseca
More portable. Based on Roland Scheidegger's idea. Tested with roundevent_test on Linux, MinGW, and MSVC. https://bugs.freedesktop.org/show_bug.cgi?id=91591 --- src/util/rounding.h | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/util/rounding.h b/src/uti