Re: [Mesa-dev] [PATCH] vc4: fix vc4_resource_from_handle() stride calculation

2016-06-15 Thread Eric Anholt
Rob Herring writes: > The expected stride calculation is completely wrong. It should > ultimately be multiplying cpp and width rather than dividing. The width > also needs to be aligned to the tiling width first before converting to > stride bytes. > > The whole stride check here is possibly poin

[Mesa-dev] [PATCH] vc4: fix vc4_resource_from_handle() stride calculation

2016-06-14 Thread Rob Herring
The expected stride calculation is completely wrong. It should ultimately be multiplying cpp and width rather than dividing. The width also needs to be aligned to the tiling width first before converting to stride bytes. The whole stride check here is possibly pointless. Any buffers which were all