Re: [Mesa-dev] [PATCH 0/2] Prevent regression with changes to nir_opt_if

2018-06-01 Thread Ian Romanick
On 06/01/2018 01:33 AM, Samuel Pitoiset wrote: > Thanks! I guess you are now okay with my nir_opt_if changes? Yeah, it should be fine. > I have one minor regression with one shader of RoTR but that shouldn't > matter. > > Series is: > > Reviewed-by: Samuel Pitoiset > > On 06/01/2018 02:21 AM,

Re: [Mesa-dev] [PATCH 0/2] Prevent regression with changes to nir_opt_if

2018-06-01 Thread Samuel Pitoiset
Thanks! I guess you are now okay with my nir_opt_if changes? I have one minor regression with one shader of RoTR but that shouldn't matter. Series is: Reviewed-by: Samuel Pitoiset On 06/01/2018 02:21 AM, Ian Romanick wrote: This series fixes the most agregious regressions caused by the nir

[Mesa-dev] [PATCH 0/2] Prevent regression with changes to nir_opt_if

2018-05-31 Thread Ian Romanick
This series fixes the most agregious regressions caused by the nir_opt_if changes, and it's somewhat helpful in its own right. The i965 driver already has a pass in the backend that cleans up if-then-else sequence that have one block (the then-block or the else-block) that is empty. As a result,