Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

2016-02-10 Thread Iago Toral
Hi Juha, On Sun, 2016-02-07 at 23:37 +0200, Juha-Pekka Heikkilä wrote: > Hi Iago, > > I know there are lot of places where there is malloc unchecked still > -- and then there is ralloc which is a story of its own. Reason why I > think checking these would be remotely useful in windows only (or >

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

2016-02-08 Thread Eero Tamminen
Hi, On 08.02.2016 00:07, Matt Turner wrote: On Sun, Feb 7, 2016 at 1:37 PM, Juha-Pekka Heikkilä wrote: I know there are lot of places where there is malloc unchecked still -- and then there is ralloc which is a story of its own. Reason why I think checking these

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

2016-02-08 Thread Ian Romanick
On 02/07/2016 02:07 PM, Matt Turner wrote: > On Sun, Feb 7, 2016 at 1:37 PM, Juha-Pekka Heikkilä > wrote: >> Hi Iago, >> >> I know there are lot of places where there is malloc unchecked still >> -- and then there is ralloc which is a story of its own. Reason why I

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

2016-02-07 Thread Matt Turner
On Sun, Feb 7, 2016 at 1:37 PM, Juha-Pekka Heikkilä wrote: > Hi Iago, > > I know there are lot of places where there is malloc unchecked still > -- and then there is ralloc which is a story of its own. Reason why I > think checking these would be remotely useful in

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

2016-02-07 Thread Juha-Pekka Heikkilä
Hi Iago, I know there are lot of places where there is malloc unchecked still -- and then there is ralloc which is a story of its own. Reason why I think checking these would be remotely useful in windows only (or other way around, not under linux kernel) is on Windows one can get the null

[Mesa-dev] [PATCH 0/2] Simple Klocwork patches

2016-02-03 Thread Juha-Pekka Heikkila
I'm thinking these things maybe could be wrapped up inside something like "#ifdef windows" or so in the future. At least for Android and Linux these are normally quite useless. /Juha-Pekka Juha-Pekka Heikkila (2): i965: in brw_link_shader() react to low memory glsl: Check for null pointer at

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

2016-02-03 Thread Iago Toral
Hi Juha, I don't know why checking for this might be more relevant in Windows, but in any case: There are a ton of other places in mesa where we allocate memory via calloc/malloc and we don't check that the allocation actually succeeded so I am not sure that fixing a couple of instances of