Re: [Mesa-dev] [PATCH 0/3] Fix racy full-vector writes for v[i].x

2015-11-10 Thread Kristian Høgsberg
On Mon, Nov 9, 2015 at 6:26 PM, Jason Ekstrand wrote: > On Mon, Nov 9, 2015 at 3:52 PM, Ian Romanick wrote: >> On 11/04/2015 03:55 PM, Jason Ekstrand wrote: >>> Here's some shader-db numbers: >>> >>> total instructions in shared programs: 6236146 -> 6255385 (0.31%) >>> instructions in affected p

Re: [Mesa-dev] [PATCH 0/3] Fix racy full-vector writes for v[i].x

2015-11-09 Thread Jason Ekstrand
On Mon, Nov 9, 2015 at 3:52 PM, Ian Romanick wrote: > On 11/04/2015 03:55 PM, Jason Ekstrand wrote: >> Here's some shader-db numbers: >> >> total instructions in shared programs: 6236146 -> 6255385 (0.31%) >> instructions in affected programs: 203629 -> 222868 (9.45%) >> helped:

Re: [Mesa-dev] [PATCH 0/3] Fix racy full-vector writes for v[i].x

2015-11-09 Thread Ian Romanick
On 11/04/2015 03:55 PM, Jason Ekstrand wrote: > Here's some shader-db numbers: > > total instructions in shared programs: 6236146 -> 6255385 (0.31%) > instructions in affected programs: 203629 -> 222868 (9.45%) > helped:118 > HURT:

Re: [Mesa-dev] [PATCH 0/3] Fix racy full-vector writes for v[i].x

2015-11-04 Thread Jason Ekstrand
Here's some shader-db numbers: total instructions in shared programs: 6236146 -> 6255385 (0.31%) instructions in affected programs: 203629 -> 222868 (9.45%) helped:118 HURT: 1989 GAINED:18 LOST:

[Mesa-dev] [PATCH 0/3] Fix racy full-vector writes for v[i].x

2015-11-04 Thread Kristian Høgsberg Kristensen
This little series fixes a problem where we lower v[i] = s to v = vector_insert(v, s, i) turning a component write into a full vector write. This used to be ok, since none of this was visible to other threads. Now with SSBOs (and compute shader SLM and tesselation outputs) this rewrite is