Re: [Mesa-dev] [PATCH 0/5] Resubmit: uninitialized warning fix + unit tests

2016-05-25 Thread Alejandro Piñeiro
Two weeks ping. As you can see on Ian email, he gave a Rb for patches 1,2,4. Added some minor comments on patch 3 (but granted the RB as far as I made those changes), and asked to add more unit tests (patch 5). When adding those unit tests, I detected a case where patch 2 was not properly raising

Re: [Mesa-dev] [PATCH 0/5] Resubmit: uninitialized warning fix + unit tests

2016-05-12 Thread Ian Romanick
Patches 1, 2, and 4 are Reviewed-by: Ian Romanick I'm sending some comments on the other two. On 05/10/2016 12:13 AM, Alejandro Piñeiro wrote: > This is a resubmit of the pending patches related with the uninitialized > warning, after two weeks since last comment. > > This resubmit series merg

[Mesa-dev] [PATCH 0/5] Resubmit: uninitialized warning fix + unit tests

2016-05-10 Thread Alejandro Piñeiro
This is a resubmit of the pending patches related with the uninitialized warning, after two weeks since last comment. This resubmit series merges two series hoping to make easier the review: * Fix the false positive with function parameters, that got a first review by Ian Romanick [1] * U