[Mesa-dev] [PATCH 0/5] glsl: Clean up linker error checking.

2013-07-27 Thread Paul Berry
I recently discovered a bug in my geometry shader branch wherein we were responding to certain kinds of link errors by calling linker_error(), but the program was still linking successfully. The root cause turned out to be that during the first half of the execution of link_shaders(), it was not s

Re: [Mesa-dev] [PATCH 0/5] glsl: Clean up linker error checking.

2013-07-28 Thread Jordan Justen
Reviewed-by: Jordan Justen On Sat, Jul 27, 2013 at 3:59 PM, Paul Berry wrote: > I recently discovered a bug in my geometry shader branch wherein we > were responding to certain kinds of link errors by calling > linker_error(), but the program was still linking successfully. The > root cause tur

Re: [Mesa-dev] [PATCH 0/5] glsl: Clean up linker error checking.

2013-07-30 Thread Ian Romanick
The series is Reviewed-by: Ian Romanick On 07/27/2013 03:59 PM, Paul Berry wrote: I recently discovered a bug in my geometry shader branch wherein we were responding to certain kinds of link errors by calling linker_error(), but the program was still linking successfully. The root cause turne