Re: [Mesa-dev] [PATCH 0/8] nir: Require numbers of components to always match

2017-03-08 Thread Connor Abbott
I agree that this is a good idea. For the series: Reviewed-by: Connor Abbott On Fri, Mar 3, 2017 at 8:12 PM, Jason Ekstrand wrote: > When NIR was first created, we were a bit lazy about numbers of components. > The rule was that a source couldn't consume more components than the thing > it was

Re: [Mesa-dev] [PATCH 0/8] nir: Require numbers of components to always match

2017-03-08 Thread Kenneth Graunke
On Friday, March 3, 2017 5:12:24 PM PST Jason Ekstrand wrote: > When NIR was first created, we were a bit lazy about numbers of components. > The rule was that a source couldn't consume more components than the thing > it was reading from. However, this leads to a lot of confusion because you > no

Re: [Mesa-dev] [PATCH 0/8] nir: Require numbers of components to always match

2017-03-08 Thread Jason Ekstrand
On Wed, Mar 8, 2017 at 4:56 PM, Eric Anholt wrote: > Jason Ekstrand writes: > > > When NIR was first created, we were a bit lazy about numbers of > components. > > The rule was that a source couldn't consume more components than the > thing > > it was reading from. However, this leads to a lot

Re: [Mesa-dev] [PATCH 0/8] nir: Require numbers of components to always match

2017-03-08 Thread Eric Anholt
Jason Ekstrand writes: > When NIR was first created, we were a bit lazy about numbers of components. > The rule was that a source couldn't consume more components than the thing > it was reading from. However, this leads to a lot of confusion because you > now have a thing sourcing from a vec4 b

Re: [Mesa-dev] [PATCH 0/8] nir: Require numbers of components to always match

2017-03-03 Thread Jason Ekstrand
+correct connor On Fri, Mar 3, 2017 at 5:12 PM, Jason Ekstrand wrote: > When NIR was first created, we were a bit lazy about numbers of components. > The rule was that a source couldn't consume more components than the thing > it was reading from. However, this leads to a lot of confusion becau

[Mesa-dev] [PATCH 0/8] nir: Require numbers of components to always match

2017-03-03 Thread Jason Ekstrand
When NIR was first created, we were a bit lazy about numbers of components. The rule was that a source couldn't consume more components than the thing it was reading from. However, this leads to a lot of confusion because you now have a thing sourcing from a vec4 but only reading two of the compon