Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-30 Thread Jason Ekstrand
On Thu, Nov 30, 2017 at 11:52 AM, Kristian Høgsberg wrote: > On Thu, Oct 19, 2017 at 11:04 AM, Jason Ekstrand > wrote: > > Not to be confused with variablePointersStorageBuffer which is the > > subset of VK_KHR_variable_pointers required to enable the extension. > > This gives us "full" support

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-30 Thread Kristian Høgsberg
On Thu, Oct 19, 2017 at 11:04 AM, Jason Ekstrand wrote: > Not to be confused with variablePointersStorageBuffer which is the > subset of VK_KHR_variable_pointers required to enable the extension. > This gives us "full" support for variable pointers. > > The approach chosen here was to do the lower

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-29 Thread Chad Versace
On Mon 06 Nov 2017, Jason Ekstrand wrote: > On Mon, Nov 6, 2017 at 7:26 PM, Jason Ekstrand <[1]ja...@jlekstrand.net> > wrote: > The tests are fixed in CL #1915.  I feel like a dork now... The CL is still languishing in Gerrit. fyi, I've pushed a branch with the CL. http://git.kiwitree.net/c

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-21 Thread Kenneth Graunke
On Thursday, October 19, 2017 11:04:02 AM PST Jason Ekstrand wrote: > Not to be confused with variablePointersStorageBuffer which is the > subset of VK_KHR_variable_pointers required to enable the extension. > This gives us "full" support for variable pointers. > > The approach chosen here was to

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-06 Thread Jason Ekstrand
On Mon, Nov 6, 2017 at 7:26 PM, Jason Ekstrand wrote: > On Mon, Nov 6, 2017 at 6:33 PM, Chad Versace > wrote: > >> On Mon 06 Nov 2017, Jason Ekstrand wrote: >> > On Mon, Nov 6, 2017 at 12:18 PM, Chad Versace <[1] >> chadvers...@chromium.org> >> > wrote: >> > >> > Jason, I tested this series

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-06 Thread Jason Ekstrand
On Mon, Nov 6, 2017 at 6:33 PM, Chad Versace wrote: > On Mon 06 Nov 2017, Jason Ekstrand wrote: > > On Mon, Nov 6, 2017 at 12:18 PM, Chad Versace <[1] > chadvers...@chromium.org> > > wrote: > > > > Jason, I tested this series against the khronos-internal vk-gl-cts > and > > found an asser

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-06 Thread Chad Versace
On Mon 06 Nov 2017, Jason Ekstrand wrote: > On Mon, Nov 6, 2017 at 12:18 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > Jason, I tested this series against the khronos-internal vk-gl-cts and > found an assertion failure in src/compiler/spirv. Any thoughts? > > I haven't d

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-06 Thread Jason Ekstrand
On Mon, Nov 6, 2017 at 12:18 PM, Chad Versace wrote: > Jason, I tested this series against the khronos-internal vk-gl-cts and > found an assertion failure in src/compiler/spirv. Any thoughts? > > I haven't debugged yet because I don't grok these parts of Mesa. > > vk-gl-cts > > commit a24448c

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-11-06 Thread Chad Versace
Jason, I tested this series against the khronos-internal vk-gl-cts and found an assertion failure in src/compiler/spirv. Any thoughts? I haven't debugged yet because I don't grok these parts of Mesa. vk-gl-cts commit a24448cdd72ffdbd8f7f571886625b8a53100979 mesa refs/tags/chadv/test/an

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-10-26 Thread Jason Ekstrand
+idr On Thu, Oct 19, 2017 at 11:04 AM, Jason Ekstrand wrote: > Not to be confused with variablePointersStorageBuffer which is the > subset of VK_KHR_variable_pointers required to enable the extension. > This gives us "full" support for variable pointers. > > The approach chosen here was to do th

[Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-10-19 Thread Jason Ekstrand
Not to be confused with variablePointersStorageBuffer which is the subset of VK_KHR_variable_pointers required to enable the extension. This gives us "full" support for variable pointers. The approach chosen here was to do the lowering to _shared intrinsics directly in spirv_to_nir instead of usin