Re: [Mesa-dev] [PATCH 00/15] nir: Rework boolean (and maybe all?) conversions

2018-11-26 Thread Timothy Arceri
On 10/11/18 3:58 am, Jason Ekstrand wrote: In case anyone is wondering my opinion based on my experience writing both patch series, I think it's decidedly in the version B camp.  The code changes required to nir_algebraic and nir_search are almost identical between the two besides the whole vir

Re: [Mesa-dev] [PATCH 00/15] nir: Rework boolean (and maybe all?) conversions

2018-11-09 Thread Jason Ekstrand
In case anyone is wondering my opinion based on my experience writing both patch series, I think it's decidedly in the version B camp. The code changes required to nir_algebraic and nir_search are almost identical between the two besides the whole virtual opcode thing and the changes to front-end

[Mesa-dev] [PATCH 00/15] nir: Rework boolean (and maybe all?) conversions

2018-11-08 Thread Jason Ekstrand
Welcome to this choose-your-own-adventure patch series! The first six patches are good-to-go regardless of choices made later. However, starting with patch 7, we have a choice to make. Version A of this series reworks NIR conversion opcodes to not have sizes and instead simply accept any source