Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-19 Thread Vladislav Egorov
19.01.2017 01:46, Ian Romanick пишет: On 01/07/2017 11:02 AM, Vladislav Egorov wrote: glcpp's printing is an obvious low hanging fruit: 1. It unnecessarily uses formatted printing to print output of preprocessing. To print just one character '+' it first uses vsnprintf("%s", "+") to

Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-18 Thread Ian Romanick
On 01/07/2017 11:02 AM, Vladislav Egorov wrote: > glcpp's printing is an obvious low hanging fruit: > > 1. It unnecessarily uses formatted printing to print output of >preprocessing. To print just one character '+' it first uses >vsnprintf("%s", "+") to calculate number of characters in

Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-08 Thread Vladislav Egorov
08.01.2017 17:05, Grazvydas Ignotas пишет: Some spelling suggestions, since you seem to be doing another version of these patches: Yes, the fuzzer uncovered many bugs and deviations in behaviour from the old flex/bison path. Trivial, but numerous. So I need some time to hunt all the problem

Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-08 Thread Grazvydas Ignotas
On Sun, Jan 8, 2017 at 4:05 PM, Grazvydas Ignotas wrote: > On Sat, Jan 7, 2017 at 9:02 PM, Vladislav Egorov wrote: >> +* >> +* Check for INT_MAX for the only reason that utility > > "... only for the only reason that ..."

Re: [Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-08 Thread Grazvydas Ignotas
Some spelling suggestions, since you seem to be doing another version of these patches: On Sat, Jan 7, 2017 at 9:02 PM, Vladislav Egorov wrote: > glcpp's printing is an obvious low hanging fruit: > > 1. It unnecessarily uses formatted printing to print output of >

[Mesa-dev] [PATCH 01/12] glcpp: Print preprocessor output to string_buffer

2017-01-07 Thread Vladislav Egorov
glcpp's printing is an obvious low hanging fruit: 1. It unnecessarily uses formatted printing to print output of preprocessing. To print just one character '+' it first uses vsnprintf("%s", "+") to calculate number of characters in the formatted string (while it's known statically), then