Re: [Mesa-dev] [PATCH 01/18] Remove glBlendColor and glBlendEquations decls from glext.h

2013-12-20 Thread Ian Romanick
On 12/13/2013 05:25 PM, Keith Packard wrote: These are duplicates from gl.h; I'm not sure which file they belong in, but you don't get to have them in both places. If you're doing something that involves defining GL_GLEXT_PROTOTYPES, you're doing it wrong. Also, unless you're sending kernel or

[Mesa-dev] [PATCH 01/18] Remove glBlendColor and glBlendEquations decls from glext.h

2013-12-13 Thread Keith Packard
These are duplicates from gl.h; I'm not sure which file they belong in, but you don't get to have them in both places. Signed-off-by: Keith Packard kei...@keithp.com --- include/GL/glext.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/GL/glext.h b/include/GL/glext.h index

Re: [Mesa-dev] [PATCH 01/18] Remove glBlendColor and glBlendEquations decls from glext.h

2013-12-13 Thread Kenneth Graunke
On 12/13/2013 05:25 PM, Keith Packard wrote: These are duplicates from gl.h; I'm not sure which file they belong in, but you don't get to have them in both places. Signed-off-by: Keith Packard kei...@keithp.com --- include/GL/glext.h | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 01/18] Remove glBlendColor and glBlendEquations decls from glext.h

2013-12-13 Thread Keith Packard
Kenneth Graunke kenn...@whitecape.org writes: NAK. These headers come directly from Khronos; we need to somehow get this fixed upstream and take their version. Until they're fixed upstream, we should fix them when incorporating them into the repository. Having broken headers in our code just