Re: [Mesa-dev] [PATCH 02/20] nir: clarify some nit_loop_info member names

2018-12-09 Thread Nils Wallménius
Den lör 8 dec. 2018 00:10 skrev Jason Ekstrand : > Replacing min with max without changing any real code always looks a biit > weird but it does make sense. :-) > > Reviewed-by: Jason Ekstrand > > On Thu, Dec 6, 2018 at 9:08 PM Timothy Arceri > wrote: > >> Following commits will introduce

Re: [Mesa-dev] [PATCH 02/20] nir: clarify some nit_loop_info member names

2018-12-07 Thread Jason Ekstrand
Replacing min with max without changing any real code always looks a biit weird but it does make sense. :-) Reviewed-by: Jason Ekstrand On Thu, Dec 6, 2018 at 9:08 PM Timothy Arceri wrote: > Following commits will introduce additional fields such as > guessed_trip_count. Renaming these will

[Mesa-dev] [PATCH 02/20] nir: clarify some nit_loop_info member names

2018-12-06 Thread Timothy Arceri
Following commits will introduce additional fields such as guessed_trip_count. Renaming these will help avoid confusion as our unrolling feature set grows. Reviewed-by: Thomas Helland --- src/compiler/nir/nir.h | 8 +--- src/compiler/nir/nir_loop_analyze.c| 14