Re: [Mesa-dev] [PATCH 03/10] i965: Don't implicitly set predicate default state in brw_CMP.

On Sun, May 25, 2014 at 11:43 PM, Kenneth Graunke wrote: > On 05/25/2014 01:02 PM, Matt Turner wrote: >> On Sun, May 25, 2014 at 1:08 AM, Kenneth Graunke >> wrote: >>> diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c >>> b/src/mesa/drivers/dri/i965/brw_clip_tri.c >>> index fdab260..5894b80

Re: [Mesa-dev] [PATCH 03/10] i965: Don't implicitly set predicate default state in brw_CMP.

On 05/25/2014 01:02 PM, Matt Turner wrote: > On Sun, May 25, 2014 at 1:08 AM, Kenneth Graunke > wrote: >> diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c >> b/src/mesa/drivers/dri/i965/brw_clip_tri.c >> index fdab260..5894b80 100644 >> --- a/src/mesa/drivers/dri/i965/brw_clip_tri.c >> +++

Re: [Mesa-dev] [PATCH 03/10] i965: Don't implicitly set predicate default state in brw_CMP.

On Sun, May 25, 2014 at 1:08 AM, Kenneth Graunke wrote: > diff --git a/src/mesa/drivers/dri/i965/brw_clip_tri.c > b/src/mesa/drivers/dri/i965/brw_clip_tri.c > index fdab260..5894b80 100644 > --- a/src/mesa/drivers/dri/i965/brw_clip_tri.c > +++ b/src/mesa/drivers/dri/i965/brw_clip_tri.c > @@ -433,

[Mesa-dev] [PATCH 03/10] i965: Don't implicitly set predicate default state in brw_CMP.

Previously, brw_CMP with a null destination implicitly set the default state to make future instructions predicated. This is messy and confusing - emitting a CMP that populates the flag register and later using it to predicate instructions are logically separate. With the main compiler, we may ev