Re: [Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

2019-07-10 Thread Alyssa Rosenzweig
> I don't think other drivers have had to do this. I've definitely > resisted stuff like that in nouveau in the past. Are you sure this is > necessary? Would be good to check if these tests pass or fail on > nouveau, for example. (Although by coincidence, they could be ending > up with zero values,

Re: [Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

2019-07-10 Thread Alyssa Rosenzweig
It's a known upstream issue; it was taken off the mustpass list but... I have issues, ok? I just really wanted 100/100 passing :) I think it was 16. On Wed, Jul 10, 2019 at 03:48:35PM +0200, Erik Faye-Lund wrote: > On Wed, 2019-07-10 at 06:24 -0700, Alyssa Rosenzweig wrote: > > Fixes a buggy dEQP

Re: [Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

2019-07-10 Thread Ilia Mirkin
On Wed, Jul 10, 2019 at 9:25 AM Alyssa Rosenzweig wrote: > > Fixes a buggy dEQP test. > > Signed-off-by: Alyssa Rosenzweig > --- > .../drivers/panfrost/ci/expected-failures.txt | 6 -- > src/gallium/drivers/panfrost/meson.build | 1 + > .../drivers/panfrost/midgard/compiler.h | 6 +

Re: [Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

2019-07-10 Thread Erik Faye-Lund
On Wed, 2019-07-10 at 06:24 -0700, Alyssa Rosenzweig wrote: > Fixes a buggy dEQP test. > Maybe you could share which test this fixes, so someone can fix it? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman

Re: [Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

2019-07-10 Thread Erik Faye-Lund
On Wed, 2019-07-10 at 06:24 -0700, Alyssa Rosenzweig wrote: > Fixes a buggy dEQP test. > > Signed-off-by: Alyssa Rosenzweig > --- > .../drivers/panfrost/ci/expected-failures.txt | 6 -- > src/gallium/drivers/panfrost/meson.build | 1 + > .../drivers/panfrost/midgard/compiler.h | 6

[Mesa-dev] [PATCH 03/11] panfrost/midgard: Flush undefineds to zero

2019-07-10 Thread Alyssa Rosenzweig
Fixes a buggy dEQP test. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/ci/expected-failures.txt | 6 -- src/gallium/drivers/panfrost/meson.build | 1 + .../drivers/panfrost/midgard/compiler.h | 6 ++ .../panfrost/midgard/midgard_compile.c| 4 + .../panfrost/mid