Re: [Mesa-dev] [PATCH 03/11] spirv: add vtn_builder_create

2018-03-16 Thread Timothy Arceri
nit: can we rename it vtn_builder_create -> vtn_create_builder with that. Reviewed-by: Timothy Arceri On 08/03/18 19:19, Alejandro Piñeiro wrote: Refactored from spirv_to_nir, in order to be reused later. --- src/compiler/spirv/spirv_to_nir.c | 48 ++- sr

[Mesa-dev] [PATCH 03/11] spirv: add vtn_builder_create

2018-03-08 Thread Alejandro Piñeiro
Refactored from spirv_to_nir, in order to be reused later. --- src/compiler/spirv/spirv_to_nir.c | 48 ++- src/compiler/spirv/vtn_private.h | 4 2 files changed, 36 insertions(+), 16 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/comp