Re: [Mesa-dev] [PATCH 03/29] mesa: Do not assert on integer-non-integer direct pack/unpack fast paths

2014-11-21 Thread Iago Toral
On Thu, 2014-11-20 at 21:35 -0800, Jason Ekstrand wrote: On Thu, Nov 20, 2014 at 9:33 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Thu, Nov 20, 2014 at 12:29 AM, Iago Toral ito...@igalia.com wrote: It is explained here:

Re: [Mesa-dev] [PATCH 03/29] mesa: Do not assert on integer-non-integer direct pack/unpack fast paths

2014-11-20 Thread Iago Toral
It is explained here: https://bugs.freedesktop.org/show_bug.cgi?id=84566#c35 So one example of this was a glReadPixels where we want to store the pixel data as RGBA UINT, but the render buffer format we read from is MESA_FORMAT_B8G8R8A8_UNORM. There are piglit tests that hit this case. Iago On

Re: [Mesa-dev] [PATCH 03/29] mesa: Do not assert on integer-non-integer direct pack/unpack fast paths

2014-11-20 Thread Jason Ekstrand
On Thu, Nov 20, 2014 at 12:29 AM, Iago Toral ito...@igalia.com wrote: It is explained here: https://bugs.freedesktop.org/show_bug.cgi?id=84566#c35 So one example of this was a glReadPixels where we want to store the pixel data as RGBA UINT, but the render buffer format we read from is

Re: [Mesa-dev] [PATCH 03/29] mesa: Do not assert on integer-non-integer direct pack/unpack fast paths

2014-11-20 Thread Jason Ekstrand
On Thu, Nov 20, 2014 at 9:33 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Thu, Nov 20, 2014 at 12:29 AM, Iago Toral ito...@igalia.com wrote: It is explained here: https://bugs.freedesktop.org/show_bug.cgi?id=84566#c35 So one example of this was a glReadPixels where we want to store

Re: [Mesa-dev] [PATCH 03/29] mesa: Do not assert on integer-non-integer direct pack/unpack fast paths

2014-11-19 Thread Jason Ekstrand
Can you remind me again as to what formats hit these paths? I remember you hitting them, but I'm still not really seeing how it happens. --Jason On Tue, Nov 18, 2014 at 1:23 AM, Iago Toral Quiroga ito...@igalia.com wrote: We can have conversions from non-integer types to integer types, so

[Mesa-dev] [PATCH 03/29] mesa: Do not assert on integer-non-integer direct pack/unpack fast paths

2014-11-18 Thread Iago Toral Quiroga
We can have conversions from non-integer types to integer types, so remove the assertions for these in the pack/unpack fast paths. It could be that we do not have all the necessary pack/unpack functions in these cases though, so protect these paths with conditionals and let _mesa_format_convert