Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-18 Thread Timothy Arceri
On 08/03/18 19:19, Alejandro Piñeiro wrote: ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 "Shader Specialization", error table: INVALID_VALUE is generated if does not name a valid entry point for

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Rob Clark
On Fri, Mar 16, 2018 at 7:48 AM, Alejandro Piñeiro wrote: > On 16/03/18 12:39, Rob Clark wrote: >> On Fri, Mar 16, 2018 at 7:27 AM, Alejandro Piñeiro >> wrote: >>> On 16/03/18 12:11, Rob Clark wrote: Just curious, how much different is this from what spirv-val does? >>> Well, spirv-val does

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Alejandro Piñeiro
On 16/03/18 12:39, Rob Clark wrote: > On Fri, Mar 16, 2018 at 7:27 AM, Alejandro Piñeiro > wrote: >> On 16/03/18 12:11, Rob Clark wrote: >>> Just curious, how much different is this from what spirv-val does? >> Well, spirv-val does a full validation of the SPIR-V binary. Here we are >> just doing

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Rob Clark
On Fri, Mar 16, 2018 at 7:27 AM, Alejandro Piñeiro wrote: > On 16/03/18 12:11, Rob Clark wrote: >> Just curious, how much different is this from what spirv-val does? > > Well, spirv-val does a full validation of the SPIR-V binary. Here we are > just doing the basic validation required by the metho

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Alejandro Piñeiro
On 16/03/18 12:14, Timothy Arceri wrote: > > > On 16/03/18 21:58, Alejandro Piñeiro wrote: >> On 16/03/18 11:47, Timothy Arceri wrote: >>> On 08/03/18 19:19, Alejandro Piñeiro wrote: >>> ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenG

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Alejandro Piñeiro
On 16/03/18 12:11, Rob Clark wrote: > Just curious, how much different is this from what spirv-val does? Well, spirv-val does a full validation of the SPIR-V binary. Here we are just doing the basic validation required by the method glSpecializeShadeARB, introduced by ARB_gl_spirv. That's the rea

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Timothy Arceri
On 16/03/18 22:11, Rob Clark wrote: Just curious, how much different is this from what spirv-val does? We are going to end up using spirv-tools from clover, so if all of this is just to avoid a dependency on spirv-tools, is it worth it? It seems like a pretty simple bit of code that mostly re

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Timothy Arceri
On 16/03/18 21:58, Alejandro Piñeiro wrote: On 16/03/18 11:47, Timothy Arceri wrote: On 08/03/18 19:19, Alejandro Piñeiro wrote: ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1     "Shader Specialization", error

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Rob Clark
Just curious, how much different is this from what spirv-val does? We are going to end up using spirv-tools from clover, so if all of this is just to avoid a dependency on spirv-tools, is it worth it? BR, -R On Thu, Mar 8, 2018 at 3:19 AM, Alejandro Piñeiro wrote: > ARB_gl_spirv adds the abilit

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Alejandro Piñeiro
On 16/03/18 11:47, Timothy Arceri wrote: > On 08/03/18 19:19, Alejandro Piñeiro wrote: > >> ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new >> method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 >>     "Shader Specialization", error table: >> >>   INVALID_VALUE is ge

Re: [Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-16 Thread Timothy Arceri
On 08/03/18 19:19, Alejandro Piñeiro wrote: ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 "Shader Specialization", error table: INVALID_VALUE is generated if does not name a valid entry point for

[Mesa-dev] [PATCH 04/11] nir/spirv: add gl_spirv_validation method

2018-03-08 Thread Alejandro Piñeiro
ARB_gl_spirv adds the ability to use SPIR-V binaries, and a new method, glSpecializeShader. From OpenGL 4.6 spec, section 7.2.1 "Shader Specialization", error table: INVALID_VALUE is generated if does not name a valid entry point for . INVALID_VALUE is generated if any element