Re: [Mesa-dev] [PATCH 04/12] mesa/format_info: Add support for the BPTC layout

2014-08-07 Thread Neil Roberts
Jason Ekstrand ja...@jlekstrand.net writes: Sorry, said that just a little early. Do we really want 4 bits for a floating-point format? How many bits does nvidia report? NVidia reports the RGB components as 8/8/8 for the two normalized formats and 32/32/32 for the two half-float formats. I

[Mesa-dev] [PATCH 04/12] mesa/format_info: Add support for the BPTC layout

2014-08-06 Thread Neil Roberts
Adds the ‘bptc’ layout to get_channel_bits. The channel bits for BPTC depend on the mode but as it only has to be an approximation we can set it to 4 like for S3TC. --- src/mesa/main/format_info.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/format_info.py

Re: [Mesa-dev] [PATCH 04/12] mesa/format_info: Add support for the BPTC layout

2014-08-06 Thread Jason Ekstrand
This looks fine to me. Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Wed, Aug 6, 2014 at 9:27 AM, Neil Roberts n...@linux.intel.com wrote: Adds the ‘bptc’ layout to get_channel_bits. The channel bits for BPTC depend on the mode but as it only has to be an approximation we can set

Re: [Mesa-dev] [PATCH 04/12] mesa/format_info: Add support for the BPTC layout

2014-08-06 Thread Jason Ekstrand
Sorry, said that just a little early. Do we really want 4 bits for a floating-point format? How many bits does nvidia report? --Jason On Wed, Aug 6, 2014 at 9:55 AM, Jason Ekstrand ja...@jlekstrand.net wrote: This looks fine to me. Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On