Re: [Mesa-dev] [PATCH 04/14] mesa: remove redundant _NEW_BUFFERS setting in ReadPixels

2013-04-22 Thread Eric Anholt
Marek Olšák writes: > already set by _mesa_readbuffer > --- > src/mesa/main/buffers.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c > index 3f5cbcd..36b0312 100644 > --- a/src/mesa/main/buffers.c > +++ b/src/mesa/main/buffers.c > @@

Re: [Mesa-dev] [PATCH 04/14] mesa: remove redundant _NEW_BUFFERS setting in ReadPixels

2013-04-15 Thread Eric Anholt
Marek Olšák writes: > The main motivation behind NewDriverState is to map GL states to driver > state groups in a driver-specific manner. For example, some driver may want > the colormask to be in the framebuffer state, while some other driver may > want the colormask to be in the blend state. So

Re: [Mesa-dev] [PATCH 04/14] mesa: remove redundant _NEW_BUFFERS setting in ReadPixels

2013-04-15 Thread Marek Olšák
The main motivation behind NewDriverState is to map GL states to driver state groups in a driver-specific manner. For example, some driver may want the colormask to be in the framebuffer state, while some other driver may want the colormask to be in the blend state. So let's say we have ctx->Driver

Re: [Mesa-dev] [PATCH 04/14] mesa: remove redundant _NEW_BUFFERS setting in ReadPixels

2013-04-15 Thread Eric Anholt
s/ReadPixels/ReadBuffer/ in the subject. I need a bit more time to think about the NewDriverState idea in the surrounding patches. I don't see there being a meaningful distinction between which state ends up in NewState versus NewDriverState in this patch series, and I'd like to actually understa

[Mesa-dev] [PATCH 04/14] mesa: remove redundant _NEW_BUFFERS setting in ReadPixels

2013-04-15 Thread Marek Olšák
already set by _mesa_readbuffer --- src/mesa/main/buffers.c |1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index 3f5cbcd..36b0312 100644 --- a/src/mesa/main/buffers.c +++ b/src/mesa/main/buffers.c @@ -645,7 +645,6 @@ _mesa_ReadBuffer(GLenum