Re: [Mesa-dev] [PATCH 04/16] glsl: Add support for new bit built-ins in ARB_gpu_shader5.

2013-04-24 Thread Matt Turner
On Mon, Apr 22, 2013 at 6:33 PM, Chris Forbes chr...@ijw.co.nz wrote: In the last hunk: + case ir_binop_bfm: + case ir_triop_bfi: These look like leftovers? -- Chris Yes, good call. I've moved them to later in the series where they're actually added (glsl: Add a pass to lower

[Mesa-dev] [PATCH 04/16] glsl: Add support for new bit built-ins in ARB_gpu_shader5.

2013-04-22 Thread Matt Turner
--- src/glsl/ir.cpp|8 +++- src/glsl/ir.h | 21 - src/glsl/ir_validate.cpp | 26 ++ src/glsl/opt_algebraic.cpp |6 +++---

Re: [Mesa-dev] [PATCH 04/16] glsl: Add support for new bit built-ins in ARB_gpu_shader5.

2013-04-22 Thread Chris Forbes
In the last hunk: + case ir_binop_bfm: + case ir_triop_bfi: These look like leftovers? -- Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 04/16] glsl: Add support for new bit built-ins in ARB_gpu_shader5.

2013-04-22 Thread Chris Forbes
Scratch that -- I see what they're for. They seem to be missing from enum ir_expression_operation though. -- Chris On Tue, Apr 23, 2013 at 1:33 PM, Chris Forbes chr...@ijw.co.nz wrote: In the last hunk: + case ir_binop_bfm: + case ir_triop_bfi: These look like leftovers? -- Chris