Re: [Mesa-dev] [PATCH 04/16] nir: add nir_lower_bool_to_float

2019-01-02 Thread Dylan Baker
Quoting Ian Romanick (2019-01-02 12:57:26) > On 12/19/18 9:25 AM, Dylan Baker wrote: > > Quoting Jonathan Marek (2018-12-19 08:39:53) > >> Mainly a copy of nir_lower_bool_to_int32, but with float opcodes. > >> > >> Signed-off-by: Jonathan Marek > >> --- > >> src/compiler/Makefile.sources

Re: [Mesa-dev] [PATCH 04/16] nir: add nir_lower_bool_to_float

2019-01-02 Thread Ian Romanick
On 12/19/18 9:25 AM, Dylan Baker wrote: > Quoting Jonathan Marek (2018-12-19 08:39:53) >> Mainly a copy of nir_lower_bool_to_int32, but with float opcodes. >> >> Signed-off-by: Jonathan Marek >> --- >> src/compiler/Makefile.sources | 1 + >> src/compiler/nir/meson.build

Re: [Mesa-dev] [PATCH 04/16] nir: add nir_lower_bool_to_float

2018-12-19 Thread Jonathan marek
Hi, No I did not see that. That version should work for me, although I don't like the lowering of nir_op_inot it has, since the backend might have something smarter to implement a "fnot" (and ior could also just be a fmax instead). On 12/19/2018 12:44 PM, Christian Gmeiner wrote: Am Mi.,

Re: [Mesa-dev] [PATCH 04/16] nir: add nir_lower_bool_to_float

2018-12-19 Thread Christian Gmeiner
Am Mi., 19. Dez. 2018 um 17:44 Uhr schrieb Jonathan Marek : > > Mainly a copy of nir_lower_bool_to_int32, but with float opcodes. > Hmmm.. are you aware of https://patchwork.freedesktop.org/patch/257867/ and

Re: [Mesa-dev] [PATCH 04/16] nir: add nir_lower_bool_to_float

2018-12-19 Thread Dylan Baker
Quoting Jonathan Marek (2018-12-19 08:39:53) > Mainly a copy of nir_lower_bool_to_int32, but with float opcodes. > > Signed-off-by: Jonathan Marek > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/meson.build | 3 +- > src/compiler/nir/nir.h

[Mesa-dev] [PATCH 04/16] nir: add nir_lower_bool_to_float

2018-12-19 Thread Jonathan Marek
Mainly a copy of nir_lower_bool_to_int32, but with float opcodes. Signed-off-by: Jonathan Marek --- src/compiler/Makefile.sources | 1 + src/compiler/nir/meson.build | 3 +- src/compiler/nir/nir.h | 1 +