Re: [Mesa-dev] [PATCH 04/28] nir: add support for flushing to zero denorm constants

2018-12-10 Thread Samuel Iglesias Gonsálvez
On 05/12/2018 18:32, Connor Abbott wrote: > Given that other places call nir_eval_const_opcode(), and they'll be > broken unless they also flush denorms, it's probably a good idea to > move all this into nir_eval_const_opcode() itself. > Thanks for the feedback. I will do this and fix the rest

Re: [Mesa-dev] [PATCH 04/28] nir: add support for flushing to zero denorm constants

2018-12-05 Thread Elie Tournier
On Wed, Dec 05, 2018 at 04:55:19PM +0100, Samuel Iglesias Gonsálvez wrote: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/compiler/nir/nir_opt_constant_folding.c | 74 +++-- > 1 file changed, 68 insertions(+), 6 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 04/28] nir: add support for flushing to zero denorm constants

2018-12-05 Thread Connor Abbott
Given that other places call nir_eval_const_opcode(), and they'll be broken unless they also flush denorms, it's probably a good idea to move all this into nir_eval_const_opcode() itself. On Wed, Dec 5, 2018 at 4:56 PM Samuel Iglesias Gonsálvez wrote: > > Signed-off-by: Samuel Iglesias Gonsálvez

[Mesa-dev] [PATCH 04/28] nir: add support for flushing to zero denorm constants

2018-12-05 Thread Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/nir/nir_opt_constant_folding.c | 74 +++-- 1 file changed, 68 insertions(+), 6 deletions(-) diff --git a/src/compiler/nir/nir_opt_constant_folding.c b/src/compiler/nir/nir_opt_constant_folding.c index