Re: [Mesa-dev] [PATCH 05/11] mesa: Implement glSpecializeShaderARB

2018-03-16 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 08/03/18 19:19, Alejandro Piñeiro wrote: From: Nicolai Hähnle v2: * Use gl_spirv_validation instead of spirv_to_nir. This method just validates the shader. The conversion to NIR will happen later, during linking. (Alejandro Piñeiro) * Use gl_shade

[Mesa-dev] [PATCH 05/11] mesa: Implement glSpecializeShaderARB

2018-03-08 Thread Alejandro Piñeiro
From: Nicolai Hähnle v2: * Use gl_spirv_validation instead of spirv_to_nir. This method just validates the shader. The conversion to NIR will happen later, during linking. (Alejandro Piñeiro) * Use gl_shader_spirv_data struct to store the SPIR-V data. (Eduardo Lima) * Use the '