Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2015-07-02 Thread Brian Paul
On 7/2/15 1:00 PM, Eric Anholt wrote: Brian Paul writes: The main issue is I need to do additional work for cube and/or cube array textures. This is still on my to-do list. Do you need this? FWIW, I just wanted this extension in X yesterday. I'm on vacation this week. I could try to lo

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2015-07-02 Thread Eric Anholt
Brian Paul writes: > The main issue is I need to do additional work for cube and/or cube > array textures. This is still on my to-do list. Do you need this? FWIW, I just wanted this extension in X yesterday. signature.asc Description: PGP signature __

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2015-07-02 Thread Ilia Mirkin
Nope, just looking over the GL 4.5 extensions, was wondering what was happening with this one. On Thu, Jul 2, 2015 at 2:14 PM, Brian Paul wrote: > The main issue is I need to do additional work for cube and/or cube array > textures. This is still on my to-do list. Do you need this? > > -Brian >

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2015-07-02 Thread Brian Paul
The main issue is I need to do additional work for cube and/or cube array textures. This is still on my to-do list. Do you need this? -Brian On 7/1/15 11:01 PM, Ilia Mirkin wrote: Brian, what happened to this series? Was there some conflict with DSA and so you held off? On Sat, Dec 13, 201

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2015-07-01 Thread Ilia Mirkin
Brian, what happened to this series? Was there some conflict with DSA and so you held off? On Sat, Dec 13, 2014 at 9:42 AM, Brian Paul wrote: > One of the two new functions in GL_ARB_get_texture_sub_image. > --- > src/mesa/main/texgetimage.c | 305 > ++--

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2014-12-18 Thread Laura Ekstrand
After sending this review, I think it would be best (to avoid a gigantic merge snarl) for me to send another patch where I manually merge this with my patch "[PATCH 29/41] main: Added entry point for glGetTextureImage." Laura On Thu, Dec 18, 2014 at 10:07 AM, Laura Ekstrand wrote: > > Brian, > >

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2014-12-18 Thread Laura Ekstrand
Brian, I dealt with a lot of the TEXTURE_CUBE_MAP stuff when I implemented GetTextureImage (in my recent DSA textures patch series). Ian and I have filed a bug on the spec for missing faces and mismatched formats/sizes. Right now, I am saying if (texObj->NumLayers < 6), throw invalid operation (n

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2014-12-18 Thread Brian Paul
On 12/17/2014 05:03 PM, Laura Ekstrand wrote: On Sat, Dec 13, 2014 at 6:42 AM, Brian Paul mailto:bri...@vmware.com>> wrote: One of the two new functions in GL_ARB_get_texture_sub_image. --- src/mesa/main/texgetimage.c | 305 ++-- s

Re: [Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2014-12-17 Thread Laura Ekstrand
On Sat, Dec 13, 2014 at 6:42 AM, Brian Paul wrote: > > One of the two new functions in GL_ARB_get_texture_sub_image. > --- > src/mesa/main/texgetimage.c | 305 > ++-- > src/mesa/main/texgetimage.h | 8 ++ > 2 files changed, 277 insertions(+), 36 deletions

[Mesa-dev] [PATCH 05/11] mesa: implement _mesa_GetTextureSubImage()

2014-12-13 Thread Brian Paul
One of the two new functions in GL_ARB_get_texture_sub_image. --- src/mesa/main/texgetimage.c | 305 ++-- src/mesa/main/texgetimage.h | 8 ++ 2 files changed, 277 insertions(+), 36 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texg